Coder Social home page Coder Social logo

Comments (9)

tomalaforge avatar tomalaforge commented on June 24, 2024 1

@ErickRodrCodes 🙏

I was going to ask the question. I don't know anything about the spanish language but when it comes to French. it's the same, we have fr-BE, fr-CA but it's almost identical.

I think having one locale is great. If in the future. there is thousands of people from different spanish countries that really doesnt' understand this spanish, we can decide to translate it.

But grouping your contribution is better, since you can review each other and have a better translation.

What do you think @eduardoRoth ? You were the one to switch to es-MX

from angular-challenges.

eduardoRoth avatar eduardoRoth commented on June 24, 2024 1

@ErickRodrCodes @tomalaforge ; I don't have any issues with merging Spanish locales. The reason for me adding one locale is that there're some changes that I would have done to words and sentences in the current Spanish one, and didn't want to just go overriding it alongside my other changes and updates.

I can create a PR to merge Spanish, and handle suggestions in separate PRs from new translations.

from angular-challenges.

nelsongutidev avatar nelsongutidev commented on June 24, 2024

Agreed @ErickRodrCodes , thanks for bringing it up. Yes, I also believe like @tomalaforge that one unified locale ES is probably best for now.

from angular-challenges.

eduardoRoth avatar eduardoRoth commented on June 24, 2024

Also, this would probably affect Portuguese translation, as right now it's Brazilian one.

from angular-challenges.

tomalaforge avatar tomalaforge commented on June 24, 2024

Yes that's true for portuguese too, but I don't know how different both language are: @kabrunko-dev Do you think having only one locale for portuguese would be enough ?

And you can do the merge @ErickRodrCodes.

from angular-challenges.

kabrunko-dev avatar kabrunko-dev commented on June 24, 2024

Hello everybody 👋

@tomalaforge, for me it's okay to use only one locale for now. There's also some differences, but like spanish and french variations in the end we can understand each other.

Also, as you said, " If in the future. there is thousands of people from different spanish countries that really doesnt' understand this spanish, we can decide to translate it." can be also applied for other languages.

from angular-challenges.

tomalaforge avatar tomalaforge commented on June 24, 2024

ok awesome so we can change the locale to pt as well instead of pt-BR and say portuguese in the menu instead of brazilian, is that ok for you ? @kabrunko-dev

from angular-challenges.

kabrunko-dev avatar kabrunko-dev commented on June 24, 2024

For me it's okay @tomalaforge

from angular-challenges.

tomalaforge avatar tomalaforge commented on June 24, 2024

Done

from angular-challenges.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.