Comments (9)
I was going to ask the question. I don't know anything about the spanish language but when it comes to French. it's the same, we have fr-BE, fr-CA but it's almost identical.
I think having one locale is great. If in the future. there is thousands of people from different spanish countries that really doesnt' understand this spanish, we can decide to translate it.
But grouping your contribution is better, since you can review each other and have a better translation.
What do you think @eduardoRoth ? You were the one to switch to es-MX
from angular-challenges.
@ErickRodrCodes @tomalaforge ; I don't have any issues with merging Spanish locales. The reason for me adding one locale is that there're some changes that I would have done to words and sentences in the current Spanish one, and didn't want to just go overriding it alongside my other changes and updates.
I can create a PR to merge Spanish, and handle suggestions in separate PRs from new translations.
from angular-challenges.
Agreed @ErickRodrCodes , thanks for bringing it up. Yes, I also believe like @tomalaforge that one unified locale ES
is probably best for now.
from angular-challenges.
Also, this would probably affect Portuguese translation, as right now it's Brazilian one.
from angular-challenges.
Yes that's true for portuguese too, but I don't know how different both language are: @kabrunko-dev Do you think having only one locale for portuguese would be enough ?
And you can do the merge @ErickRodrCodes.
from angular-challenges.
Hello everybody 👋
@tomalaforge, for me it's okay to use only one locale for now. There's also some differences, but like spanish and french variations in the end we can understand each other.
Also, as you said, " If in the future. there is thousands of people from different spanish countries that really doesnt' understand this spanish, we can decide to translate it." can be also applied for other languages.
from angular-challenges.
ok awesome so we can change the locale to pt
as well instead of pt-BR
and say portuguese
in the menu instead of brazilian
, is that ok for you ? @kabrunko-dev
from angular-challenges.
For me it's okay @tomalaforge
from angular-challenges.
Done
from angular-challenges.
Related Issues (20)
- challenge 11: typo in doc and config error in HOT 13
- The constraints of the "Projection" challenge lack clarity in their objective. HOT 1
- Typo in getting started guide HOT 1
- [Docs] - Translate the rest of the challenges to Spanish HOT 4
- links don't match HOT 3
- giscus dark mode HOT 7
- [Docs] New I18n language pt-BR HOT 4
- (Challenge 1) Additions to project's code and challenge's doc HOT 6
- Translation FR
- Translation ES HOT 5
- Translation PT HOT 4
- Translation file skeleton (TO BE EDITED WHEN NEW CHALLENGE IS ADDED)
- i18n for shared custom components HOT 3
- Translation es-MX HOT 1
- Update Dependencies HOT 1
- Answer author tag vs answer tag HOT 1
- NgRx Notification directions need clarification HOT 1
- Translation RU HOT 3
- Repo size HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from angular-challenges.