Comments (1)
Yeah, the current implementation is definitely not the best and most clean, but it works.
The majority of the work in terms of searching for local tracks is actually being done before processMediaWrappers is being called. In the GetMediaItemsRunnable all tracks are being searched for and parsed. Then the resulting MediaWrapper objects are stored in the database "DatabaseHelper.get().addMedias(mediaWrappers);". This MediaWrapper database is not being wiped and re-filled every time.
All that's done in processMediaWrappers is to iterate through all MediaWrappers and parse them into ScriptResolverTrack objects. Those objects are then being stored in another database (UserCollectionDb), which is the one you were talking about. It's being wiped and re-filled every time.
This implementation with 2 separate databases is mostly just a remnant from a previous implementation.
A better way to do it would of course be to get rid of the UserCollectionDb entirely and pull all the data directly from the MediaWrapper database.
Please always feel free to post PRs for these kinds of things.
from tomahawk-android.
Related Issues (20)
- Internet disconnect issue
- [Suggestion] F-Droid HOT 10
- Gmusic resolver does not work HOT 7
- Crash Followed by Blank App & No Menu Options
- Make app compatible with Android auto
- Super laggy on Nexus 6P
- One of setGitDir or setWorkTree must be called. HOT 1
- easy enhancement - amazon.co.jp server support HOT 6
- app is not working after login to hatchet. HOT 2
- app opens many blank webviews
- Local opus files ignored if Title tag contains a dot HOT 4
- subsonic URLs are generated with erroneous extra forwardslash
- App carshes upon opening in OnePlus 3
- Crashed when pressing plus button in my favorites screen.
- Spotify don't connect HOT 9
- Intermittently long waiting time for search result to be displayed
- Can't register for Hatchet HOT 1
- Spotify wont connect HOT 2
- Tomahawk music player crashes when connected to Station
- Folders and Playlists
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tomahawk-android.