Coder Social home page Coder Social logo

Comments (1)

mrmaffen avatar mrmaffen commented on August 27, 2024

Yeah, the current implementation is definitely not the best and most clean, but it works.
The majority of the work in terms of searching for local tracks is actually being done before processMediaWrappers is being called. In the GetMediaItemsRunnable all tracks are being searched for and parsed. Then the resulting MediaWrapper objects are stored in the database "DatabaseHelper.get().addMedias(mediaWrappers);". This MediaWrapper database is not being wiped and re-filled every time.
All that's done in processMediaWrappers is to iterate through all MediaWrappers and parse them into ScriptResolverTrack objects. Those objects are then being stored in another database (UserCollectionDb), which is the one you were talking about. It's being wiped and re-filled every time.
This implementation with 2 separate databases is mostly just a remnant from a previous implementation.

A better way to do it would of course be to get rid of the UserCollectionDb entirely and pull all the data directly from the MediaWrapper database.

Please always feel free to post PRs for these kinds of things.

from tomahawk-android.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.