Comments (4)
We had contemplated receiver but thought for new users, coming from other languages, it might be mistaken as an instance (or some such concept) of
Receiver
, while from (weak/flawed) memory it is aFuture
.
No, it isn't a Future
. It is an instance of the type tokio::sync::broadcast::Receiver
.
As for the word "monitor", I find that word very unnatural here. If we are to rephrase the sentence, I would prefer this:
/// Shutdown signals are received using a `broadcast::Receiver`.
from mini-redis.
Changing it to listen
or receiver
sounds reasonable to me. I do not think that collect
and gather
would be good names.
from mini-redis.
Thanks for the feedback. We had contemplated receiver
but thought for new users, coming from other languages, it might be mistaken as an instance (or some such concept) of Receiver
, while from (weak/flawed) memory it is a Future
.
We're still working through this example so will likely wait a while before making an PR - to ensure we haven't misunderstood.
For future reference, we also thought this line (signalling is a synonym for sending):
/// Shutdown is signalled using a `broadcast::Receiver`.
might be better phrased:
/// Shutdown signals are monitored via a `broadcast::Receiver`.
Which of course suggests that monitor
is a better replacement term for notify
?
from mini-redis.
receiver
it is then.
from mini-redis.
Related Issues (20)
- The `chat` example is empty HOT 2
- Potential bug in read_frame if we receive 2 frames ready in the buffer? HOT 1
- Benches for mini-redis HOT 2
- why is `frame` serialized to string should be removed the first element?
- Using BTreeSet instead of BTreemap HOT 1
- The `Frame::Integer` should be signed 64-bit integer HOT 2
- panic in VSCode terminal HOT 1
- Fails when install mini-redis with the latest rustc version HOT 1
- theoretically bug in db.set method? HOT 2
- Why itparsing is set to fail when frame is not array?
- dtrace user stacks not generating HOT 1
- The server test key_value_timeout has a race condition causing hang HOT 4
- why so slow compared with redis? HOT 10
- how to config memory to be used? HOT 3
- updates? HOT 6
- Question: `shutdown_complete_rx` never used in the `Listner` HOT 2
- Fails with Latest Rust HOT 1
- bug in implementation of display for frame
- Add (optional) OpenTelemetry + Xray integration HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mini-redis.