Coder Social home page Coder Social logo

Comments (12)

tobybatch avatar tobybatch commented on July 30, 2024

I will take a look but this may be an issue for kimai app itself,

from kimai2.

stevenhrabok avatar stevenhrabok commented on July 30, 2024

Hi @tobybatch, I'm experiencing the same issue (when preview or print invoice).

I attempted to look at the kimai and nginx container logs and it seems we only see HTTP 200's.
When I click Preview I get http://mykimaihost:8001/en/invoice/?searchTerm=&daterange=2020-01-01+-+2020-01-31&customer=1&project=1&activity=1&users%5B%5D=1&tags=&exported=1&template=1&preview=
When I do print I get http://mykimaihost:8001/en/invoice/?searchTerm=&daterange=2020-01-01+-+2020-01-31&customer=1&project=1&activity=1&users%5B%5D=1&tags=&exported=1&template=1&create=

When searching Kimai Github Issues, I'm not seeing any bug reports regarding this issue.
Is there anything I can provide to assist to find the source of the problem?

from kimai2.

kevinpapst avatar kevinpapst commented on July 30, 2024

@stevenhrabok can you please test some POST forms (edit/create something). Do they work?
Now test some forms that utilize GET parameter (eg. search, invoice, pagination). Do they work?
I'd say #66 is related.

from kimai2.

tobybatch avatar tobybatch commented on July 30, 2024

@Schrolli91 have you time to look at this? It could be nginx an forwarding issue, and I'm slammed at work right now.

from kimai2.

stevenhrabok avatar stevenhrabok commented on July 30, 2024

@tobybatch Found the fix, attempted to submit a branch with PR, but didn't have permission.

https://github.com/tobybatch/kimai2/blob/master/compose/nginx_site.conf#L14

needs to be changed to try_files $uri $uri/ /index.php$is_args$args;

the missing $is_args$args was causing the uri arguments to be lost.

from kimai2.

kevinpapst avatar kevinpapst commented on July 30, 2024

@stevenhrabok awesome, nice finding! I looked through it, but didn't spot it.
FYI - you have to fork the repository, then create the branch, do your changes, push the branch. Now you can create a PR
Bildschirmfoto 2020-01-16 um 17 16 57

from kimai2.

tobybatch avatar tobybatch commented on July 30, 2024

Top work, thanks you. I'll get that fix in place over the weekend

from kimai2.

Schrolli91 avatar Schrolli91 commented on July 30, 2024

ok - I'm too late :-D
@stevenhrabok thank you for your investigations

from kimai2.

AlxBe avatar AlxBe commented on July 30, 2024

Perfect! Thank you very much.

from kimai2.

tobybatch avatar tobybatch commented on July 30, 2024

@Schrolli91 Can you fix this please? I'm a nginx n00b and I can seem to get it to work.

from kimai2.

Schrolli91 avatar Schrolli91 commented on July 30, 2024

@stevenhrabok can you please take a look at the PR #71

atm i'm not able to test these changes properly - should be confirmed before we'll merge this to the master branch

from kimai2.

Schrolli91 avatar Schrolli91 commented on July 30, 2024

closed because PR is on the way

from kimai2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.