Bug: Shapes increasing in size after a stack and cut about shapez.io

[dengr1065]

stacker: counterintuitive, but technically not a bug. will be changed soon
cutter: there's an empty layer behind! it will be brought to bottom one.

[tobspr]

What @dengr1065 said. Will soon be obsolete

[cyantree]

Will the cutter part be obsolete too? If not, I've prepared a possible fix for it. I can also create a PR if wanted.

shape_definition.js

    cloneFilteredByQuadrants(includeQuadrants) {
        const newLayers = this.internalCloneLayers();
        let lastNonEmptyLayer = -1;
        for (let layerIndex = 0; layerIndex < newLayers.length; ++layerIndex) {
            const quadrants = newLayers[layerIndex];
            let anyContents = false;
            for (let quadrantIndex = 0; quadrantIndex < 4; ++quadrantIndex) {
                if (includeQuadrants.indexOf(quadrantIndex) < 0) {
                    quadrants[quadrantIndex] = null;
                } else if (quadrants[quadrantIndex]) {
                    lastNonEmptyLayer = layerIndex;
                }
            }
        }

        // Remove top most empty layers which aren't needed anymore
        if (lastNonEmptyLayer !== newLayers.length - 1) {
            newLayers.splice(lastNonEmptyLayer + 1);
        }

        return new ShapeDefinition({ layers: newLayers });
    }

This works by not removing every empty layer but only the top most empty ones.

[LeeSaferite]

@dengr1065 @tobspr

stacker: counterintuitive, but technically not a bug. will be changed soon

Out of curiosity, regardless of things being changed soon, why would this be considered normal behavior?

[dengr1065]

stacker stacks per-layer, it's too hard to implement such logic accidentally 🙂

[LeeSaferite]

So it's not simply stacking the full shape from the right on top of the shape from the left and instead it's stacking each quadrant from the right on the quadrant from the left?

[dengr1065]

it "moves/stacks" one layer from right shape on the left one, checking whether they can flatten