Coder Social home page Coder Social logo

Comments (8)

acdha avatar acdha commented on July 19, 2024

Ah, I should correct the sort order for that - that's definitely wrong.

The other difference is really a philosophical one: I'm not sure whether we should be storing every commit or only the ones which are associated with a benchmark run. The Github API doesn't allow ranged queries but I could request every commit in a branch and filter the list.

from codespeed.

acdha avatar acdha commented on July 19, 2024

acdha/codespeed@b7c2cfc3d9bb2eed4431 fixes the sort order issue

from codespeed.

tobami avatar tobami commented on July 19, 2024

Re storing commits, I thought first of storing all commit logs in the Codespeed DB, as that allows among other things for faster response time. But that is really overkill. IMHO, it is a bad idea to replicate data that is best kept at the source. Data that belongs to the commits being tested does concern Codespeed (well, at least commit dates).

from codespeed.

acdha avatar acdha commented on July 19, 2024

That's my view as well: while writing the github backend I found myself wondering how much it'd make sense to aggressively link to sites like github, bitbucket, google code, sourceforge, etc. which have some sort of UI and usually other niceties beyond just the commit logs.

from codespeed.

tobami avatar tobami commented on July 19, 2024

Yeah, linking more aggressively does make sense. That way you can immediately go to a changelog's diff, inside the niceties of your repository UI.

from codespeed.

smarr avatar smarr commented on July 19, 2024

And another thing I noticed to be different from the current git backend:

The git backend seems to show all commits from the range between the last data point in the DB and the point that is currently shown.
With the github backend only the latest commit is shown.

I noticed after switching to the github backend because we wanted the revision links in the view, but then the commits were gone.
Still, the links are highly appreciate and useful! :)

from codespeed.

smarr avatar smarr commented on July 19, 2024

This should also be fixed with #40

from codespeed.

tobami avatar tobami commented on July 19, 2024

I am closing it then. Thanks for pointing out.

from codespeed.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.