Coder Social home page Coder Social logo

Comments (9)

tmspzz avatar tmspzz commented on May 29, 2024 1

There is a full new release that includes this fix and #57 , get it with brew upgrade rome

from rome.

tmspzz avatar tmspzz commented on May 29, 2024

@erichoracek binary repos are not supported at the moment. I was unaware of this feature in Carthage.

I will add support for binary only frameworks, I need to study a little how deal with this case.

I'll also correct the exit status on parse errors.

from rome.

erichoracek avatar erichoracek commented on May 29, 2024

Is there any reason why Rome would need to cache prebuilt frameworks for binary Cartfile references? Since these have no artifacts that need caching, I'd be fine if Rome just ignored them outright.

from rome.

tmspzz avatar tmspzz commented on May 29, 2024

I guess a few reasons could be:

  • to avoid a download if are using the local cache option.
  • to store frameworks privately in your S3 bucket.

I can start with trying to tolerate parse errors in the Cartfile.resolved

from rome.

erichoracek avatar erichoracek commented on May 29, 2024

Carthage has an internal cache for prebuilt binaries at:

~/Library/Caches/org.carthage.CarthageKit/binaries/

so I don't think that you'd be avoiding unnecessary downloads.

As such, as far as I can tell, the only benefit that Rome support for binary Cartfile references would have is storing binary frameworks in your S3 bucket.

The ideal behavior for us would just be to ignore these frameworks outright since we don't care about having these frameworks stored in our bucket. However, I can see how that may be unexpected behavior for some users.

from rome.

tmspzz avatar tmspzz commented on May 29, 2024

I think a download can be avoided if the frameworks is placed directly at the correct path in Carthage/Build/{platform} and carthage just invoked with build

To make this work properly I think that Rome would need to resolve the binary json and figure out a couple of things. After that it would generate a Romefile.resolved (the irony) where it stores the missing information for these cases.

Immediate plan:

  • Start simple and make the parsing fault tolerant (thus ignoring binary lines)

Further enhancement:

  • try the resolved path

from rome.

erichoracek avatar erichoracek commented on May 29, 2024

That seems reasonable—as long as binary lines are ignored for the time being and do not cause the command to fail that should work for us. 👍

from rome.

tmspzz avatar tmspzz commented on May 29, 2024

Please try pre-release https://github.com/blender/Rome/releases/tag/v0.10.2.23

from rome.

erichoracek avatar erichoracek commented on May 29, 2024

@blender that fixed it, thanks!

from rome.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.