Comments (9)
There is a full new release that includes this fix and #57 , get it with brew upgrade rome
from rome.
@erichoracek binary repos are not supported at the moment. I was unaware of this feature in Carthage.
I will add support for binary only frameworks, I need to study a little how deal with this case.
I'll also correct the exit status on parse errors.
from rome.
Is there any reason why Rome would need to cache prebuilt frameworks for binary
Cartfile references? Since these have no artifacts that need caching, I'd be fine if Rome just ignored them outright.
from rome.
I guess a few reasons could be:
- to avoid a download if are using the local cache option.
- to store frameworks privately in your S3 bucket.
I can start with trying to tolerate parse errors in the Cartfile.resolved
from rome.
Carthage has an internal cache for prebuilt binaries at:
~/Library/Caches/org.carthage.CarthageKit/binaries/
so I don't think that you'd be avoiding unnecessary downloads.
As such, as far as I can tell, the only benefit that Rome support for binary
Cartfile references would have is storing binary
frameworks in your S3 bucket.
The ideal behavior for us would just be to ignore these frameworks outright since we don't care about having these frameworks stored in our bucket. However, I can see how that may be unexpected behavior for some users.
from rome.
I think a download can be avoided if the frameworks is placed directly at the correct path in Carthage/Build/{platform}
and carthage just invoked with build
To make this work properly I think that Rome would need to resolve the binary json and figure out a couple of things. After that it would generate a Romefile.resolved
(the irony) where it stores the missing information for these cases.
Immediate plan:
- Start simple and make the parsing fault tolerant (thus ignoring binary lines)
Further enhancement:
- try the resolved path
from rome.
That seems reasonable—as long as binary
lines are ignored for the time being and do not cause the command to fail that should work for us. 👍
from rome.
Please try pre-release https://github.com/blender/Rome/releases/tag/v0.10.2.23
from rome.
@blender that fixed it, thanks!
from rome.
Related Issues (20)
- Xcode version specific upload/download HOT 4
- Concurrent downloads for remote cache HOT 1
- Nexus as example engine HOT 4
- [Question] Framework produces both static and dynamic output HOT 4
- Losing debug capability when using cached builds downloaded by Rome HOT 2
- Static folder isn't uploaded to remote server on Xcode 12 HOT 4
- Rome won't upload all downstream re-built frameworks HOT 3
- Rome sometimes printing partial output HOT 1
- Rome not failing when engine exit code is not zero HOT 1
- Issues running Rome with --no-skip-current HOT 6
- Needs to be updated to support XCFrameworks. HOT 13
- When using currentMap its not possible to reuse the generated binaries HOT 3
- Rome crashes when downloading dependencies HOT 1
- Skip bcsymbolmaps and dsyms when uploading/downloading a framework HOT 4
- Issues with Rome for xcframeworks HOT 24
- Failed to install latest ROME in MAC HOT 1
- using rome download --concurrently with --use-xcframeworks leads to io error: openBinaryFile: resource busy (file is locked)
- Add Rome arm64 release artifact HOT 3
- Error if carthage cache and rome cache have a file and directory with the same name
- Build failure with ghc 9.6.2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rome.