CHANNEL_ERROR - unexpected method in connection state running in AMQP::Protocol::Channel::Open about amqp

[weifeng365]

I discover that the channel didn't close after publishing message in queue.rb every time.
So more message sending, more channels opening, you can execute command 'rabbitmqctl list_channels' to see it.
I fix this issue and test 1000k times, it's just OK. The following is patch. I don't know whether such fixing is suitable, if you have the better idea about this please tell me.

----------------------------------------amqp.patch-------------------------------------------------------
diff -uNr ./amqp/lib/mq/queue.rb ./amqp_fix//lib/mq/queue.rb
--- ./amqp/lib/mq/queue.rb 2010-10-15 14:28:09.340387446 +0800
+++ ./amqp_fix//lib/mq/queue.rb 2010-10-15 14:30:25.413032791 +0800
@@ -361,6 +361,7 @@
end

 def publish data, opts = {}

•  @mq.set_closing true
  

  exchange.publish(data, opts)
  end

@@ -452,4 +453,4 @@
@eXchange ||= Exchange.new(@MQ, :direct, '', :key => name)
end
end
-end
\ No newline at end of file
+end
diff -uNr ./amqp/lib/mq.rb ./amqp_fix//lib/mq.rb
--- ./amqp/lib/mq.rb 2010-10-15 14:28:09.340387446 +0800
+++ ./amqp_fix//lib/mq.rb 2010-10-15 14:29:49.892032825 +0800
@@ -811,6 +811,10 @@

 prefetch(@prefetch_size) if @prefetch_size

end

• def set_closing closing

•  @closing = closing
  

• end

private

@@ -844,4 +848,4 @@
def MQ.id
Thread.current[:mq_id] ||= "#{hostname.strip}-#{Process.pid}-#{Thread.current.object_id}"
end
-end
\ No newline at end of file
+end

[tmm1]

This patch does not make sense. MQ and queues are meant to be re-used, you should not be creating a new one every time you want to publish a message.

[weifeng365]

hi tmm1, you're right. The fact is at https://github.com/kennethkalmer/ruote-amqp/issues/#issue/3

[botanicus]

Closed as invalid.