Coder Social home page Coder Social logo

Comments (6)

tlberglund avatar tlberglund commented on August 20, 2024

Could you post a snippet of the changelog, or if you're able, just share the whole changelog as a Gist? If intellectual property concerns prevent you from sharing the whole thing, maybe just the part with the path in question would be helpful.

from groovy-liquibase.

ErwinvanBrandwijk avatar ErwinvanBrandwijk commented on August 20, 2024

The changelog isn't important for this bug.

In DATABASECHANGELOG it saves FILENAME, that contains the path and name of the changelog.

Example: I run changelog.groovy
databaseChangelog() {
include(path: "changelogs")
}

changelog_1.groovy in map changelogs\ (changelogs\changelog.groovy)
databaseChangelog() {
.....
}

Now when you use liquibase core on windows it replaces \ for / and saves it in the database:
| 1 | erwin | changelogs\changelog_1.xml | 2011-03-15 16:46:16 |

With your plugin it won't replace \ for / but just deletes it. So result in database:

   | 1 | erwin | changelogschangelog_1.groovy | 2011-03-15 16:46:16 |

The big problem is that you can't make a rollback because path isn't correct.

(I think something in the parser of liquibase core replaces \ for /. I'm gonna take a look at it today)

from groovy-liquibase.

tlberglund avatar tlberglund commented on August 20, 2024

I am still unable to duplicate this. Could you create example changelogs and post them to the issue? Be sure to note what directory each is in (as you did in your description here). I realize this is a pain, but I need to be sure I understand the problem first!

from groovy-liquibase.

ErwinvanBrandwijk avatar ErwinvanBrandwijk commented on August 20, 2024

SOLVED

Add this line of code to GroovyLiquibaseChangelogParser

physicalChangeLogLocation = physicalChangeLogLocation.replaceAll("\\\\", "/")

See my fork.
Closing if it is adopted in master

from groovy-liquibase.

tlberglund avatar tlberglund commented on August 20, 2024

Committed to master. Give it a spin, and close it if you agree that it works.

from groovy-liquibase.

ErwinvanBrandwijk avatar ErwinvanBrandwijk commented on August 20, 2024

It is working, closing

from groovy-liquibase.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.