tkem / openlap Goto Github PK

Should probably pass sleepOnPause: false to serial.open().

• Apparently, the Bluetooth dialog sometimes "hides" the USB dialog when a USB device is connected and Bluetooth is not enabled. Thus, and as a general usability improvement, it may be preferable to not ask the user to enabled Bluetooth (which is only supported on Android, anyway). The Bluetooth status can be polled on a regular basis, or the new BLE state callbacks can be used when they become available in ionic-native.
• Backends (and plugins in general) should be more platform-aware, e.g. BLE should only be used when running on a device, and corovarduino only when running on Android. This should avoid spurious error messages when running in the browser, and maybe improve future iOS and/or Ionic View compatibility.
• The Demo backend may be disabled when running on a device in production mode. Thus, if Bluetooth is not enabled and no USB device connected, the backend list will be empty. In this case, a helpful message ("enable Bluetooth or connect USB device") can be shown...
• "USB Serial" should be renamed "Serial USB OTG" for clarity.

Fall back on ionic Toast for development only.
Need to handle clicks (hide) and replace, though.

• Exponential backoff
• Handle timer reset during race/qualifying

After reviewing the different alternatives, the preferred way would be to

• simply use LocalStorage for testing in the browser, since items can be easily changed
• use NativeStorage in an app, since this seems to be the most "lightweight" alternative for persisting on app updates

For use with LocalStorage, an optional prefix should be supported for testing multiple apps on localhost.

Only relevant for "race" mode. Maybe also add something like "n seconds to go" for qualifying.

Open Lap should support i18n. For starters, German translations should be added (target market and available resources).
TBD:

• Use Angular i18n or ng2-translate
• Localized TTS messages
• Translate leaderboard?

For improved accessibility, race events should not only be announced using TTS, but also displayed on screen (marquee?). Can/should reuse user settings.

Implementation hint: maybe don't stop the timer, just stop the counter!

At least in landscape mode - wouldn't take too much space and may improve usability regarding driver/colors/etc, settings.

At least when running in the emulator, there are several issues with Android 4.4:

• Showing the chequered flags distorts header title.
• Significant black border between content and footer.
• Stripes aren't slanted.
• Scrollbar to the right of content.

Sometimes it's easier to identify cars by color than by ID.

Currently only activated for lap-based races.

Collect and display more data during a race, for example

• individual lap times
• changes in position
• time/lap of pit stops
• etc.
  Data should be displayed as graphs (using HTML canvas) or in table form, and maybe exported as CSV.

Need to distinguish defaults (value unknown) from explicitly set values. Maybe also rename menu entry from "Car Setup" to "Tuning" to better distinguish from "Settings"?

It is quite unlikely that this will work with Android <4.4:

<preference name="android-minSdkVersion" value="19"/>

There's a setting for "False start", but is it ever triggered?

This should be changeable in settings (new look & feel category?)

• Move to separate module
• Evaluate stripe as SVG
• Check row margins/padding issues
• Re-check 4, 5, 7, and 10 inch displays (and larger ones, e.g. TV, too)

Probably need to check if device (esp. Blueetooth) is available (while splashscreen is shown)...
TBD: What if not?

Clearer, also used in ARC.

The leaderboard shows different information based on device orientation. Currently this only changes when the board gets updated. Orientation events should be used instead.

Leaderboard should display green "up" or red "down" arrow if position has changed since last lap (unless pit or finished icons are displayed).
Details TBD.

Visible in licenses page, for example. Somewhat irritating with dark theme.

Should change speed/brake/fuel settings for all cars. Maybe also add button to (re-)apply settings.

Add mode where every driver must finish all set laps. TBD: How to handle time-based races.

Test case: CU goes to sleep and is reset. Even though automatic reconnect won't work, pressing "Reconnect" in connection menu should perform a clean disconnect/connect.

F1 TV broadcasts seem to use red "PIT" for cars entering pit lane and white "PIT" for cars during pit stops and leaving pit lane. Distinction could be made by first fuel increment, but yellow background should go, anyway.

For example, switching between app and connection menu no longer works.

TBD: Does it make sense to "stop" a practice session?
Restart seems useful, though.

Apparently, the CU ignores the reset command when "paused", i.e. when start lights are on.
Therefore, if a race is started with start lights active, fuel will not be reset to maximum level.
This seems also to be the case with other apps, but possible workarounds should still be investigated.

Filtering by UUID doesn't seem to work well on Android, so all scanned BLE devices are currently displayed, including tooth brushes, etc.
Manually filtering by name/regex might be an option, but should be made configurable for easier debugging.

Currently, vehicles/drivers are only displayed in the leaderboard after crossing the finish line at least once.
Showing all vehicles with a non-zero fuel value may improve usability.

Speak when car enters pit (except when finished).

When leaving the Speech settings, sometimes the last message is repeated. Probably an RX issue in RaceControl.

[x] Review settings (especially section titles).
[x] Review messages.
[x] Review licenses.
[x] Review default colors.

Probably an Ionic issue: input loses focus when tapping the clear (x) button.

• Countdown in Qualifying mode?
• Control positions from app?

First car crossing start/finish line should set total laps to "1", as "lap 0" is rarely used in professional motor sport.

TBD: Leaderboard "laps" counter.

May be helpful when racing with multiple drivers. Should be added to general options.

There should be an option to reset all stored user settings to default values.

There should be an option to restart or prematurely stop ("red flag") a race or qualifying session without going through the side menu. Restart may also apply to practice mode.
This should probably be implemented using a popover/menu on the leaderboard page. If the race hasn't finished, restart should use a confirm dialog.

Add an option to impose penalties on a driver; time penalties should be most common, but drive-through penalties may also be possible. See e.g. https://www.formula1.com/en/championship/inside-f1/rules-regs/Licenses_driving_protocol_and_penalties.html or http://www.fiawec.com/presentation/regulation.html for inspiration.
At least during qualifying, canceling a driver's (last) lap time may also make sense.

Start light resets mask, so mask should be reset when lights go back to zero (check behavior when setting mask if lights already count down).
Reconnect has potentially similar behavior.

If a lap-based race is terminated early, e.g. by timeout or using the context menu, a "Final lap" message may still occur.

• refactor into proper Angular2 modules
• evaluate @ionic/storage (sqlite?)
• use new build environment
• add resources to git (simplifies build)
• check dev vs. prod wrt demo backends
• check .gitkeep in www wrt cordova
• remove .editorconfig
• re-check rxjs imports (tree-shaking)

Integrate with current ErrorHandler; also evaluate popups for severe errors ("this shouldn't have happened")

Cars "in pit" should probably be set to "finished" automatically.

Too much table layout weirdness...

If a car crosses the finish line for the first time after a race is stopped, it will have to finish one lap until the car is flagged as "finished". This should happen immediately, or new cars should be ignored after race is finished (e.g. by setting mask to active entries).