Bugs when accessing Google about oauth2

[niemyjski]

Nice find. We'll try and fix this in #70

[knightmeister]

Fantastic. I have branched Oauth2 if I get a chance to fix it myself I will
and send a PR.

On Wednesday, 17 June 2015, Blake Niemyjski [email protected]
wrote:

Nice find. We'll try and fix this in #70
#70

—
Reply to this email directly or view it on GitHub
#73 (comment).

Sent from my phone - please excuse any terseness

[niemyjski]

@knightmeister I closed it because I've made some changes that I want to get reviewed, but I think fixes this issue. Can you please review my latest commit (and read the comment.

[knightmeister]

@niemyjski The diff looks like it will address the first issue I raised, I will test it tonight and let you know for sure if it closes that. The other part of the issue is that OAuth2 expects a refresh_token to be returned by Google (in Ouath2Client)

if (GrantType != "refresh_token")
                RefreshToken = (string) ParseTokenResponse(response.Content, RefreshTokenKey);

I went and did some reading at Google (https://developers.google.com/identity/protocols/OAuth2WebServer) and Google will not return the refresh_token unless you're requesting offline access, which I'm not.

Do you want me to raise another issue for the above?

[niemyjski]

I changed it to make it optional because I don't think those fields
will be populated by everyone (thoughts on this). You could create a new
issue if you'd like :) But I don't see people requesting offline access. I
wouldn't use this library if it forced me to request above normal
permissions (as I won't use any service that forces me to give them my
friends list etc..). If you think this is an issue (my change) please open
a new issue for the refresh token.

[niemyjski]

Please let me know how testing goes :).

[knightmeister]

@niemyjski Sure, will do. I'll be home in about 10 hours and I'll test it then.

[knightmeister]

@niemyjski Sorry for being a day late, but yes I can confirm this works now without issue.

[niemyjski]

@knightmeister Sweet thanks! Now I just need to get the build passing and release a new package :)

[niemyjski]

@titarenko can you give me access to teamcity so I can deploy a release.

[titarenko]

I tried yesterday, but unfortunately, I haven't found the way to add new user under my account. BTW, build is failing. It seems that acceptance tests project is missing reference to FluentAssertions.

[niemyjski]

hmm, I'll try and take a look they were passing the other day. Any chance you can change the password and email it to me and we can share it?