Google client's GetUserInfo throws ArgumentNullException about oauth2

[agibalov]

Fixed by changing

scope="https://www.googleapis.com/auth/userinfo.email"

to

scope="https://www.googleapis.com/auth/userinfo.profile https://www.googleapis.com/auth/userinfo.email"

Not sure if it's a workaround or by design.

[titarenko]

Hi,

Thank you for update! And excuse me for late response.

Yes, when there is no (or not enough) persmissions, Google will answer with error instead of access token. That response is not handled properly, causing faceless ArgumentNullException with poor context.

What I will do next is proper handling of error responses for GoogleClient. And yes, this solution described by is closer to "by design" than to "workaround".

Thanks again for helping to ensure better quality of OAuth2 library!

[rtumaykin]

Actually this is not a google that throws this exception. When you ask to provide only email and nothing else, all other properties such as First name, Last name, etc aren't passed back and therefore the method used in UserInfo creation throws an exception as it does not handle null values.

[niemyjski]

Yes, this is logged in a second issue. It has to do with not using SafeGet. Would you mind submitting a pull request for this?

[niemyjski]

I'm closing this as a duplicate of #69.