Comments (2)
Hey @rgl, thanks for the feedback. I'm curious about "make file filename mandatory". Would you mind expanding on this idea?
In regard to "anchor the regex to the end of line", what do you think we gain by capping the name in this way?
"is there a reason for not using a query string alike syntax?"
The reason is that this code was taken from the work already done to enable otel in Boots proper. https://github.com/tinkerbell/boots/blob/129caee6916a2ef9a5cb4af216141654b0bc6e77/cmd/boots/tftp.go#L120
from ipxedust.
Hey @rgl, thanks for the feedback. I'm curious about "make file filename mandatory". Would you mind expanding on this idea?
the regex .*
means its optional, that is, it matches zero or more characters.
In regard to "anchor the regex to the end of line", what do you think we gain by capping the name in this way?
prevent it from being interpreted as something else? that way, the id would be always at the end of the string. not at the middle.
"is there a reason for not using a query string alike syntax?" The reason is that this code was taken from the work already done to enable otel in Boots proper. https://github.com/tinkerbell/boots/blob/129caee6916a2ef9a5cb4af216141654b0bc6e77/cmd/boots/tftp.go#L120
I'm not sure how picky the tftp clients are, but stashing an id in a filename using a regular char (-
) is quite odd for me; I would prefer a more structured way (like a query string).
from ipxedust.
Related Issues (13)
- Issue with latest builds of iPXE on Mellanox ConnectX HOT 2
- Issue with LetsEncrypt certificates HOT 2
- Update repo secret HOT 11
- Issue with latest builds of iPXE on 25 gigabit Intel 810
- Do not modify the http object logger HOT 1
- Change repository name to `tinkerbell/ipxe` HOT 3
- Container image build and push to quay.io/tinkerbell
- This repo should have a contributor's guide.
- Embedded script suppresses drop-to-shell from iPXE default HOT 1
- iPXE fails to boot when using the latest LetsEncrypt trust chains HOT 6
- Minimizing boot time by reducing interface boot attempts in the ipxedust script
- Possible nil pointer error
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ipxedust.