Comments (8)
I've now added all desired variables: REDIS_{HOST,PORT,USER,PASSWORD,DB}
.
I've released this as part of v3.4.11
.
It should be available when this pipeline succeeds: https://gitlab.com/timvisee/send/-/pipelines/305718044
from send.
Separate variables are good too, as long as I can specify all of them (host/port/username/pw/db).
from send.
You can also set the port and password through a separate variable:
Lines 62 to 76 in 385ac59
But I agree that supporting the more conventional URL would be better.
from send.
Oh, that's good enough, thanks! I'm trying to set up Send using Compose at the moment, and this seems adequate.
I don't know if you'd be interested to add support, but I wrote a tool for easier deployment of apps such as this one. It's still early, but it's quite useful to me, at least: https://pypi.org/project/docker-harbormaster/
from send.
Oh, that's good enough, thanks!
Great. I'll leave it open as tracking issue for Redis URL support to be implemented.
I don't know if you'd be interested to add support, but I wrote a tool for easier deployment of apps such as this one. It's still early, but it's quite useful to me, at least: https://pypi.org/project/docker-harbormaster/
Sounds cool. What would 'adding support' mean, having to provide a compose file?
You might find this template useful: https://github.com/timvisee/send-docker-compose
from send.
Yes, it's just providing a compose file with the {{ HM_DATA_DIR }}/my_data:/some_data_dir
volumes defined.
Then you could tell people to just add:
repositories:
timvisee-send:
url: https://github.com/timvisee/send.git
to their config and it would be automatically spun up. It's probably too early for me to push it very hard, I was just wondering whether something like this would be interesting to app developers.
from send.
I added more documentation to the Docker / Docker Compose configs for the REDIS_HOST
, REDIS_PORT
, and REDIS_PASSWORD
options here:
Personally I don't think Redis URL support is worth adding, given these options are already present. But I don't have strong opinions either way as long as separate vars stay supported.
imo a higher priority task is to add a REDIS_DB
option to select which Redis DB to use e.g. 0
, 1
, etc. (ability to specify DB no. would also be required to support Redis URLs anyway).
from send.
I wonder what the more conventional approach would be?
I've mostly seen separate variables, but maybe Redis URLs are used elsewhere. I'd be happy with both.
from send.
Related Issues (20)
- Fix permission on upload folder in docker HOT 2
- Anyone figured out a way to force dark mode? HOT 4
- Any way to make the upload accessible only for internal users and download for external? HOT 2
- If you click the logo then you're redirected to the homepage. How can I turn this off? HOT 2
- Logo reverse back after npm run build
- Error with redirection because of the # in the last part of the link url
- Add `unlimited` as an option for max downloads when sharing a file
- Uploading a folder not working HOT 2
- CUSTOM_DESCRIPTION does not seem to work
- Using send with password behind apache reverse proxy failed HOT 2
- Uploads fail after Send has been running for a extended period fo time HOT 1
- Can`t install Send
- Is it possible to recover an expired link data? HOT 1
- customizing the text under Simple, private file sharing HOT 2
- Is there a possibility to keep the unexpired send-archive always visible? HOT 1
- [FEATURE REQUEST] Add folder picker option like WeTransfer HOT 3
- [Request] ARM64 Support HOT 1
- Download URL accessible but files won't download. HOT 3
- Docker Compose Install - Customization HOT 1
- Feature Request: View-Only Mode HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from send.