Comments (13)
Do you have a use case where a more specific expiry time like you describe would be very much desirable? Because I do think the current implementation is 'good enough' for most cases.
In my case, I was sending the document late on a Thursday evening. I wanted to give the recipient two business days to download the document, so wanted to enter "4 days". As it is, I used 7 days and I guess that was fine. So I agree with you it wasn't really "very much desirable." I was just being pedantic. :)
I didn't personally think the text box (integer) + select box (units) would be more confusing to the average web user. It seems like a pretty simple UI to me, although I'm not a UI expert.
The simple/advance option also seems like it could work nicely. Although more development work needed there.
Thanks for the dialogue and congrats on your project hitting the top of HN.
from send.
@rsyring you may already be aware, but you can set the EXPIRE_TIMES_SECONDS
config option to customize the preset options in the UI dropdown, e.g.
EXPIRE_TIMES_SECONDS=3600,86400,604800,2592000,31536000
(the first value e.g. 3600
is used as the UI default)
You do have to preset these options ahead of time, but you can add as many as you want to have more granular choices than just the default 300,3600,86400,604800
.
This doesn't solve your request directly, but it may be helpful to people arriving on this ticket from Google wondering how to customize that dropdown (as I did),
from send.
I guess a different option would be a single text box with the ability to enter values like "30m", "12h", "3d". Same as ffsend
uses. Might not be as intuitive for non-technical users though.
from send.
I think this is done to keep the interface as simple as possible. Adding more free input fields may become confusing or annoying to use (quickly).
Do you have a use case where a more specific expiry time like you describe would be very much desirable? Because I do think the current implementation is 'good enough' for most cases.
Also, would adding more duration options by default in the drop down be good enough?
from send.
I agree that having preset options is simpler and more than likely good enough for most cases.
Perhaps adding a toggle to the right for advanced/custom duration options could be a happy medium?
from send.
Yes, that sounds like a fair medium.
from send.
Can i work on this issue.
I have read all the above discussion and i can implement something hybrid (Simple + Flexible).
This will take no more space than the current dropdown is taking.
Link this is how ui will look after
embeding select box in input field.
from send.
@maskmanlucifer Sure. Give it a shot!
from send.
Okk thank you i'll work on this.
from send.
I have another user experience improvement suggestion.
Problem :
For now if i am sending more than one files through one link.
Then the downloaded folder will be zipped.
But if we consider all the scenario's like --
- Non-tech user -- Not much experienced with zip/unzip folder,files.
- Smart phone user -- Most of the unzipping solutions start with downloading files app.
From my experience most of the users share files on smart phones ( I am college student and quite often i send assignments , or some xyz pdf's to my friends on whatsapp).
Here "send" makes sharing multiple files easier by sharing only a link to all friends but if they will be on smart phones
then this will be painful task to get real files from downloaded zipped folder.
Solution :
There can be a download icon ahead of each file on download page along with a download all button at the bottom.
So that Instead of downloading a zip folder a user can download pdf's seprately.
Now for lesser number of files above solution is quite good bcoz i'll rather click few icons to download pdf's
Rather than downloading zipped folder and extracting content from that folder.
For large number of files both clicking icons multiple times and unzipping folder will take same effort.
One more thing is giving icon ahead of each file gives a sense of selectivity like say i combined 4 files intended to be downloaded by 4 different users then they can download which pdf they want not whole folder.
What do you think about this ????.
from send.
For now if i am sending more than one files through one link.
Then the downloaded folder will be zipped.
But if we consider all the scenario's like --1. Non-tech user -- Not much experienced with zip/unzip folder,files. 2. Smart phone user -- Most of the unzipping solutions start with downloading files app. From my experience most of the users share files on smart phones ( I am college student and quite often i send assignments , or some xyz pdf's to my friends on whatsapp). Here "send" makes sharing multiple files easier by sharing only a link to all friends but if they will be on smart phones then this will be painful task to get real files from downloaded zipped folder.
Solution :
There can be a download icon ahead of each file on download page along with a download all button at the bottom.
So that Instead of downloading a zip folder a user can download pdf's seprately.Now for lesser number of files above solution is quite good bcoz i'll rather click few icons to download pdf's
Rather than downloading zipped folder and extracting content from that folder.
For large number of files both clicking icons multiple times and unzipping folder will take same effort.
One more thing is giving icon ahead of each file gives a sense of selectivity like say i combined 4 files intended to be downloaded by 4 different users then they can download which pdf they want not whole folder.What do you think about this ????.
I'd definitely like that, but: this is currently hard to implement, and would require significant file handling/cryptography changes.
The current implementation (with a ZIP archive) was likely chosen because it was easy to implement on top of the single-file upload system.
There are some other problems when implementing such a system:
- Browsers don't properly support initiating multiple downloads
- Download limits are weird with multiple files
A nice middle ground could be to handle ZIP extracting within the browser itself, though I don't know how good such thing will work.
I don't want to go through the trouble to implement this because I sadly don't have time for it. This is something to discuss in a different issue anyway.
from send.
I will create a new issue for this so that in future you or someone else want's to make those changes can find this new issue.
One more thing i am kind of beginner to make those UI changes , after going through the code part of that drop down i realised that creating new text field and drop down will involve few calculation and it's very simple in current UI.
Because number of seconds are simply pre-calculated and placed and grabbed from value of options.
So for now i am not working on this issue :(
you can add above comment in my newly created issue so anyone can get ideas about implementation complexity of above suggestion (ZIP one).
from send.
@maskmanlucifer how is this work going? did you open a fork/pr?
from send.
Related Issues (20)
- Any way to make the upload accessible only for internal users and download for external? HOT 2
- If you click the logo then you're redirected to the homepage. How can I turn this off? HOT 2
- Logo reverse back after npm run build
- Error with redirection because of the # in the last part of the link url
- Add `unlimited` as an option for max downloads when sharing a file
- Uploading a folder not working HOT 2
- CUSTOM_DESCRIPTION does not seem to work
- Using send with password behind apache reverse proxy failed HOT 2
- Uploads fail after Send has been running for a extended period fo time HOT 1
- Can`t install Send
- Is it possible to recover an expired link data? HOT 1
- customizing the text under Simple, private file sharing HOT 2
- Is there a possibility to keep the unexpired send-archive always visible? HOT 1
- [FEATURE REQUEST] Add folder picker option like WeTransfer HOT 3
- [Request] ARM64 Support HOT 1
- Download URL accessible but files won't download. HOT 3
- Docker Compose Install - Customization HOT 1
- Feature Request: View-Only Mode HOT 2
- [Security issue]: Password bruteforcing HOT 4
- Is this project still mentained? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from send.