Comments (2)
Is it possible that some files were causing silent errors (non-existent script references or something similar) that could have affected the total coverage? So, basically, now with 1.0.8 I fixed some such errors and you're actually getting more total statements in your scripts (meaning it covers more scripts that it did before)? Could you actually compare the total statements numbers between reports from 1.0.7 and 1.0.8 (and the set of files reported by Saga, not expected to be reported).
It's just that I'm using it myself for a pretty big project and the coverage numbers didn't change a bit between those versions, and I didn't make any changes to the instrumenter or the actual data collection routines apart from trying to make sure that even if a test fails dramatically, it wouldn't affect other test runs... Could you double-check the numbers for me?
from saga.
Hi Timur:
It must have been something in what was checked in to our SVN repository. I re-ran the CI job and the coverage numbers did not change. I will close this issue.
Thanks
Mike
On May 19, 2012, at 4:28 AM, Timur Strekalov wrote:
Is it possible that some files were causing silent errors (non-existent script references or something similar) that could have affected the total coverage? So, basically, now with 1.0.8 I fixed some such errors and you're actually getting more total statements in your scripts (meaning it covers more scripts that it did before)? Could you actually compare the total statements numbers between reports from 1.0.7 and 1.0.8 (and the set of files reported by Saga, not expected to be reported).
It's just that I'm using it myself for a pretty big project and the coverage numbers didn't change a bit between those versions, and I didn't make any changes to the instrumenter or the actual data collection routines apart from trying to make sure that even if a test fails dramatically, it wouldn't affect other test runs... Could you double-check the numbers for me?
Reply to this email directly or view it on GitHub:
#29 (comment)
from saga.
Related Issues (20)
- Add total coverage stats to CSV report HOT 1
- lcov and cobertura reports sources paths HOT 5
- Non instrumented sources still affect execution time. HOT 7
- Can not run by PhantomJS
- Jasmine Angularjs Services code coverage don't work HOT 1
- No instrumentation inside iframes
- GenericInstrumentingBrowser doesn't stop proxy
- WARN com.github.timurstrekalov.saga.core.TestRunCoverageStatisticsCallable - Error running test ... null HOT 2
- Saga is looking for a new maintainer HOT 5
- xml output format
- Generating 1% coverage although unit tests runs normally HOT 1
- If -DskipJasmineTests flag is specified, then code coverage is not skipped HOT 1
- TypeError during run
- Using a jasmine custom runner and jasmine-maven-plugin? HOT 1
- running saga without using maven HOT 2
- could not execute reports for jasmine - backbone application
- Fails with newer versions of htmlunit HOT 2
- Not generating coverage for all files
- saga does not generate correct report for jasmine test cases
- How to define webDriverCapabilities ?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from saga.