Coder Social home page Coder Social logo

Comments (8)

vchuravy avatar vchuravy commented on August 29, 2024 1

Timings should probably exclude or special handle custom abstract interpreters.

cc: @aviatesk

from snoopcompile.jl.

maleadt avatar maleadt commented on August 29, 2024 1

Would a viable solution be to specify a module whose code would not be precompiled?

GPU and CPU code is often part of the same module; disabling based on the AbstractInterpreter (involved) seems like the best way.

from snoopcompile.jl.

aviatesk avatar aviatesk commented on August 29, 2024

I believe this is basically JuliaLang/julia#48453. If so, GPUCompiler can implement a workaroud on its side. xref: https://github.com/aviatesk/JET.jl/blob/c0adbac27844dd07ee1df7e92689fdc571acba85/src/analyzers/jetanalyzer.jl#L44-L56

from snoopcompile.jl.

vchuravy avatar vchuravy commented on August 29, 2024

We will likely run into that next, but this is more that a custom absint is reporting it's timings and those are taking as truth by SnoopCompile. We should note Wich AbsInt cause a timings entry to create

from snoopcompile.jl.

timholy avatar timholy commented on August 29, 2024

This should be addressed now in Precompiler, since that's the future. (I don't think I can transfer to an organization.) Would a viable solution be to specify a module whose code would not be precompiled?

Note Precompiler/SnoopPrecompile is best for intervening at the "root" of inference, i.e., if the given method is dispatched at runtime. If it's deeper into an inferrable callgraph, we'd have to write code to look for it. In either case, I think the only option would be to nix the entire tree; caching part of an inferrable callgraph but omitting other parts introduces all sorts of trouble.

from snoopcompile.jl.

vchuravy avatar vchuravy commented on August 29, 2024

Fixed in JuliaLang/julia#49391 which is also part of 1.9.0-rc3

from snoopcompile.jl.

timholy avatar timholy commented on August 29, 2024

Thanks!

from snoopcompile.jl.

timholy avatar timholy commented on August 29, 2024

With exclusion, we may need to do some work to ensure whole "inference trees" are really ready to go, cf JuliaLang/julia#35972. But that's clearly not 1.9 work.

from snoopcompile.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.