Coder Social home page Coder Social logo

Comments (7)

johan-carlberg avatar johan-carlberg commented on May 18, 2024 1

@quite Works fine on my macOS from simplify-agent, both building and running.

from tkey-ssh-agent.

mchack-work avatar mchack-work commented on May 18, 2024

Please see branch simplify-agent for a first stab at this. It works fine on Linux. What about macOS?

from tkey-ssh-agent.

quite avatar quite commented on May 18, 2024

Nice! I noticed one thing. Re-plugging TKey while agent is running causes it to appear on the next /dev/ttyACMx. I guess it happens because we have the dev open, and when TKey is plugged in again, the next available has to be used. Would be nice to avoid this happening. But not sure if that's doable. We can't detect if a serial port is "alive", can we? Maybe if we had some flow control? If not, perhaps it would have to be done on a higher level. In this case USB, but that would lead us towards platform-specifics right?

Another work around could be to have tkey-ssh-agent continuously talk ping/pong with TKey, to detect when it disappears. But that might introduce other complexities...

from tkey-ssh-agent.

quite avatar quite commented on May 18, 2024

@mchack-work I've pushed to the simplify-agent branch. No more hogging of the serial port.

I did not add any "pinning" of the pubkey. I think it has to be thought through. What should it accomplish, how it can in reality help the user, UX etc. It is also tricky to do it consistently, because the signerapp might already be loaded when tkey-ssh-agent starts.

from tkey-ssh-agent.

quite avatar quite commented on May 18, 2024

@mchack-work i pushed a WIP commit that tries to explore pinning/notification possibilites. It's now also a draft PR #48

from tkey-ssh-agent.

quite avatar quite commented on May 18, 2024

I moved that WIP commit to simplify-agent-wip.

Would you try out how this simplify-agent branch works on macos @johan-carlberg ? (same signer/app.bin as before)

from tkey-ssh-agent.

quite avatar quite commented on May 18, 2024

We've merged this. The pubkey pinning is left out for now, saved in branch agent-pubkey-pinning

from tkey-ssh-agent.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.