Comments (6)
The "make verilator" target will be fixed. Not sure if we should run it as part of CI though. So "make", to build the whole FPGA including FW, and "make lint" should be in CI. IMHO.
from tillitis-key1.
I'll start looking into this. Possibly asking OlofK for help.
from tillitis-key1.
I pushed a container image built from contrib/Dockerfile
to ghcr.io/tillitis/tkey-builder so it can be used by Github Actions. Not sure if we can keep it there since it's 2.3 GiB.
Also, see #56 for some podman targets including a podman-run-make
which actually builds the bitstream using a podman container.
from tillitis-key1.
I've added basic CI. On push to main and on PR it does:
- build all
- check fw C code fmt
- I also added spdx-ensure script like I did in the apps repo. But it is not enabled, as we have many files in hw/boards/ and hw/production_test/ that either need the SPDX tag, or should be marked in the script as not needing the tag.
[ ] should also domake verilator
, but it is currently broken @secworks
Also @secworks I see we have a make lint
target that uses verilator for linting, but there are quite some lint_issues.txt that should be fixed before we can run it automatically (perhaps some are related to verilator build currently breaking)
from tillitis-key1.
Regarding the warnings in lint_issues. All but one relates to issues in the ice40 cell library, and ports not assigned by Yosys when instantiating the cells. This is external to our design. The final warning relates to PicoRV32 using both blocking and non-blocking assignments for the same signal. This is bad coding, but will break the CPU functionality. Since we instantiate the PicoRV32 as a component, I've decided to ignore it too.
from tillitis-key1.
No we chose to not actually run verilator for now. And leave the spdx-ensure out for now.
from tillitis-key1.
Related Issues (20)
- Clean up lint warnings. Again HOT 2
- Add context when sending device app HOT 1
- Run SPDX check in CI
- Update linter to Verilog-2005 HOT 2
- Add build of FPGA design with Icarus
- Add Icarus Verilog to tools installed HOT 2
- Try to remove all VERSION fields from cores
- Add more (security) code checkers to CI HOT 1
- Optimize FPGA design for clock frequency
- Change name of the FPGA design
- Remove outdated docs
- Verilog linter warnings
- Add a Verilog formatter
- Make testbenches self testing, and with correct exit code
- Idea: ability (but not enforced) to clear (or R/W) CDI HOT 4
- Improve community information about the project HOT 1
- Increase clock frequency of application_fpga HOT 2
- Clean up UDI and UDS implementation as well as udi_uds_patch program
- Add support for client based device reset HOT 14
- support for OpenPGP? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tillitis-key1.