MSS: Recursed proxy branches are not cancelled about sipservlets

[GoogleCodeExporter]

The attached path and new file contain the changes to add a new test case that 
reproduces the issue.
If I locally modify the throwExceptionIfCannotCancel in ProxyImpl.cancel then 
the test passes.

Original comment by [email protected] on 29 Mar 2012 at 2:12

Attachments:

• issue2.diff
• Redirector.java

[GoogleCodeExporter]

Original comment by jean.deruelle on 8 Jun 2012 at 9:17

• Changed state: NEw
• Added labels: Roadmap-Fix

[GoogleCodeExporter]

Original comment by jean.deruelle on 8 Jun 2012 at 9:17

• Changed state: New

[GoogleCodeExporter]

Original comment by jean.deruelle on 16 Aug 2012 at 8:10

• Added labels: MSS-2.0.0.FINAL
• Removed labels: MSS-1.8.0.FINAL

[GoogleCodeExporter]

Original comment by jean.deruelle on 16 Aug 2012 at 8:24

• Added labels: MSS-2.1.0.FINAL
• Removed labels: MSS-2.0.0.FINAL

[GoogleCodeExporter]

We've fixed this in a different way - instead of making Proxy.cancel() keep 
going, we modified ProxyBranchImpl to track if a final response has been 
received and if so then do nothing in ProxyBranch.cancel(). See the attached 
patch which should be a diff against tag release-2.0.0.FINAL.

I've not explicitly tested this patch - instead, it was tested in passing as 
part of some other work which relied on being able to call Proxy.cancel() after 
having previously cancelled a ProxyBranch.

Original comment by [email protected] on 30 Apr 2013 at 9:18

Attachments:

• mobicents-ProxyBranchImpl-cancel-2.diff

[GoogleCodeExporter]

Original comment by jean.deruelle on 5 Jul 2013 at 7:44

• Added labels: MSS-3.0.0.FINAL
• Removed labels: MSS-2.1.0.FINAL

[GoogleCodeExporter]

Hello,

I'm facing a similar problem with MSS 2.0.0.
In my mind whatever is the error encountered while canceling one branch, it 
should not prevent other branches to be canceled.
Indeed a check can be done before canceling a branch as proposed before.

Regards.

Original comment by [email protected] on 12 Feb 2014 at 4:09

Attachments:

• issue2.patch

[GoogleCodeExporter]

Original comment by jean.deruelle on 18 Apr 2014 at 9:16

• Changed state: Started
• Added labels: TelScale-7.0.2.GA

[GoogleCodeExporter]

This issue was updated by revision 04f086a88d08.


Fix (different than the ones proposed) + non regression tests
avoid throwing exception as it has impact on performance and also make sure the 
exception is still thrown if the branch has no child branches as specified by 
the javadoc

(cherry picked from commit 2962771cda5c0799a9e29668c2b87aace7ddf85c)
(cherry picked from commit 73fc360d4d4f3239faebec54c8cf5a9c705675f3)

Original comment by [email protected] on 25 Apr 2014 at 9:43

[GoogleCodeExporter]

Original comment by jean.deruelle on 25 Apr 2014 at 9:44

• Changed state: Fixed

[GoogleCodeExporter]

Original comment by [email protected] on 25 Aug 2014 at 10:52

• Added labels: MSS-2.1.0.FINAL
• Removed labels: MSS-3.0.0.FINAL