Coder Social home page Coder Social logo

Comments (8)

issuehunt-oss avatar issuehunt-oss commented on May 20, 2024

@joseconstela has funded $50.00 to this issue.


from tideflow.

issuehunt-oss avatar issuehunt-oss commented on May 20, 2024

@joseconstela has funded $100.00 to this issue.


from tideflow.

bobthekingofegypt avatar bobthekingofegypt commented on May 20, 2024

I thought I'd have a look at this. Few things I'm not sure about

  • Screenshot shows a save button in the sidebar, is that intentional? How should that save button function compared to the workflow save button? I added a done button for now that just hides the sidebar.
  • What should happen to the edit text link in the card when the side panel is open, I've hidden it for now but not sure how that is for usability.
  • when you create a new workflow it defaults to editing the first card, it's hard to understand the link between the sidebar and the currently editing card, especially on a wide monitor where the side bar is quite far away. Maybe a different background color for currently active card or some other visual link. Or not start in edit mode.
  • handling responsiveness, this wont really work well on mobile, I'm not sure there is a mobile strategy yet but this panel is absolutely positioned with a high z-index so will cover everything. It would probably need to be modal on mobile in the future.

from tideflow.

joseconstela avatar joseconstela commented on May 20, 2024

Hello @bobthekingofegypt

Thanks for your points and suggestions!

  • save button in the sidebar: The save button on the sidebar is meant to only save the settings for the selected step, not the entire flow. Hiding the sidebar works perfectly for this. So changing the copy to "Done" is perfect as in your PR :)

One behaviour I've encountered: the settings doesn't seem to get stored if you hide and re-open a task - and the card title doesn't updates.

Untitled

  • edit text link in the card and defaults to editing the first card I think both of your points on not starting in edit mode and having a different background color for currently active card are the way to go for usability and ux. 💯

  • handling responsiveness very valid points! I would consider it mobile-friendly down the road, not just now.

from tideflow.

joseconstela avatar joseconstela commented on May 20, 2024

I've pushed new changes into the master branch that disables the auto editing the first card, and hightlights the task that is in edit-mode.

Captura de pantalla 2020-04-26 a las 22 11 49

from tideflow.

bobthekingofegypt avatar bobthekingofegypt commented on May 20, 2024

Having never used meteor I was sort expecting it to all be magically reactive I didn't realise the in-progress forms where just hidden. I've added another changes that replicates that behaviour by having invisible sidebars for each step that track the changes until it is saved.

Highlight color looks nice.

from tideflow.

joseconstela avatar joseconstela commented on May 20, 2024

Thanks @bobthekingofegypt this looks stunning! Yeah you are right. I would have expected the same, but it's Blaze, and me doing front-end stuff 🤣

I've made one change in top. Let me know what you think :)

from tideflow.

issuehunt-oss avatar issuehunt-oss commented on May 20, 2024

@joseconstela has rewarded $135.00 to @bobthekingofegypt. See it on IssueHunt

  • 💰 Total deposit: $150.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $15.00

from tideflow.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.