Coder Social home page Coder Social logo

Bug on about elasticdownload HOT 15 CLOSED

tibolte avatar tibolte commented on August 15, 2024
Bug on

from elasticdownload.

Comments (15)

Tibolte avatar Tibolte commented on August 15, 2024

Good input, I'll try to improve what you pointed out.

from elasticdownload.

Ashok-Varma avatar Ashok-Varma commented on August 15, 2024

@Tibolte thankyou verymuch.
Damn good library, and especially the support till 2.2 was great

from elasticdownload.

Ashok-Varma avatar Ashok-Varma commented on August 15, 2024

@Tibolte can you inform me once its fixed. I have nearly 50k users. So i can't implement it in my app until the bug is fixed

from elasticdownload.

Tibolte avatar Tibolte commented on August 15, 2024

Sure you'll be notified here, I am doing it on my spare time, which is not easy to find these days ;) I hope to fix it by the end of the week.

from elasticdownload.

Tibolte avatar Tibolte commented on August 15, 2024

I think what you observed is the view restoring its state, I didn't handle it. I'm currently working on a branch, I made some changes so we show the download button when restoring the view state. Can you just tell me what colors you want customizable on the view? That'll help me set-up a new release.

from elasticdownload.

Ashok-Varma avatar Ashok-Varma commented on August 15, 2024

@Tibolte

  1. Download Icon color

public static Drawable getTintedDrawable(Drawable d, int color) {
Drawable wrappedDrawable = DrawableCompat.wrap(d);
DrawableCompat.setTint(wrappedDrawable, color);
return wrappedDrawable;
}
You need latest support library to use that method

  1. Color Surrounding the DownloadIcon,which is same as string color.

These are two main changes that need to be changed, If you wish you can also add for text color...etc

I am updating my app this weekend you can keep :- play.google.com/store/apps/details?id=com.ashokvarma.cocguidewiki
Thanks to you, You decreased the amount of work i have to do

from elasticdownload.

Ashok-Varma avatar Ashok-Varma commented on August 15, 2024

You need latest support library to use that method

from elasticdownload.

Tibolte avatar Tibolte commented on August 15, 2024

Allright, these are good ideas 👍 I'll see what I can do.

from elasticdownload.

Tibolte avatar Tibolte commented on August 15, 2024

@Ashok-Varma sorry for the delay. I've been looking for solutions on how to dynamically change colors on path groups, this is harder than it looks. I'm wondering if that's really possible to do it. The only customizable color I can offer now is the background (green on your screenshots) behind the animated view. Let me know if those features can wait. I'd like to release the fix with restoring state.

from elasticdownload.

Ashok-Varma avatar Ashok-Varma commented on August 15, 2024

@Tibolte yeah you can release, the fix with restoring state, now.
Those features can wait.
And will this update solve #25 issue ??

from elasticdownload.

Tibolte avatar Tibolte commented on August 15, 2024

Let me see if I can solve #25 today. I'll try to release something this evening. I'll probably open an issue regarding the colors separately.

from elasticdownload.

Ashok-Varma avatar Ashok-Varma commented on August 15, 2024

I will open issue regarding feature mark it as a feature.

from elasticdownload.

Ashok-Varma avatar Ashok-Varma commented on August 15, 2024

Issue opened @Tibolte

from elasticdownload.

Tibolte avatar Tibolte commented on August 15, 2024

The fix for restoring view state is released under version 1.0.4, it will be available any time soon with Maven. Couldn't get time for #25.

from elasticdownload.

Tibolte avatar Tibolte commented on August 15, 2024

1.0.4 is out, restoring state should be fixed then.

from elasticdownload.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.