Comments (3)
I ran some tests with various python installers. Only encountering problem with Python 3.11 on my system.
Base case:
On Windows 11 with Python 3.8.10 installed.
Build C:\git\edk2-edkrepo\dist\EdkRepoSetup-3.1.0.0.exe with Python 3.8.10
Install edkrepo 3.1.0 through EdkRepoSetup-3.1.0.0.exe
Uninstalled Python 3.8.10 using python-3.8.10-amd64.exe
Test 0: Fail (readme issue)
Attempt to install with no python installed.
"Error: Python version 3.8.8 or later is required to run EdkRepo. Please install it before continuing."
edk2-edkrepo readme shows "Python 3.5 or later" as Pre-Requisites, not "3.8.8".
readme needs to update python version requirement.
https://github.com/tianocore/edk2-edkrepo/blob/main/README.md
Test python 3.9.13: Pass
Install python-3.9.13-amd64.exe with default installation settings
Install edkrepo 3.1.0 through EdkRepoSetup-3.1.0.0.exe
Installation Successful
run some test commands:
edkrepo manifest
edkrepo clone
edkrepo status
edkrepo combo
edkrepo checkout
edkrepo sync -u
uninstall python-3.9.13-amd64.exe
delete any remaining content of C:\Users[username]\AppData\Local\Programs\Python
Test python 3.10.9: Pass
Install python-3.10.9-amd64.exe with default installation settings
Install edkrepo 3.1.0 through EdkRepoSetup-3.1.0.0.exe
Installation Successful
run some test commands:
edkrepo manifest
edkrepo clone
edkrepo status
edkrepo combo
edkrepo checkout
edkrepo sync -u
uninstall python-3.10.9-amd64.exe
delete any remaining content of C:\Users[username]\AppData\Local\Programs\Python
Test python 3.11.1: Fail
Install python-3.11.1-amd64.exe with default installation settings
Install edkrepo 3.1.0 through EdkRepoSetup-3.1.0.0.exe
Installation Error: Installation Failed.
"""
File "C:\Users[username]\AppData\Local\Programs\Python\Python311\Lib\site-packages\edkrepo\commands\command_factory.py", line 32, in _is_command
if func[0] == 'get_metadata' and len(inspect.getargspec(func[1])[0]) == 1:
^^^^^^^^^^^^^^^^^^
AttributeError: module 'inspect' has no attribute 'getargspec'. Did you mean: 'getargs'?
Unable to launch preferred entry point. Launching default entry point edkrepo.edkrepo_cli.py
Installation Error:
System.InvalidOperationException: generate-command-completion-script failed with status 1
at TianoCore.EdkRepoInstaller.InstallWorker.PerformInstall(Action2 ReportComplete, Action
1 ReportProgress, Action1 AllowCancel, Func
1 CancelPending)
at TianoCore.EdkRepoInstaller.ProgressWindow.WorkerThread()
Installation Failed.
"""
from edk2-edkrepo.
Python 3.11 deprecated inspect.getargspec()
https://docs.python.org/3.11/library/inspect.html
Python 3.8 and Python 3.9 and Python 3.10 and Python 3.11 support getfullargspec() as "usually a drop-in replacement" for getargspec().
https://docs.python.org/3.8/library/inspect.html
https://docs.python.org/3.9/library/inspect.html
https://docs.python.org/3.10/library/inspect.html
https://docs.python.org/3.11/library/inspect.html
Replacing both instances of getargspec() with getfullargspec(), and the EdkRepoSetup-3.1.0.0.exe installer can be built and run on Windows 11 with python-3.11.1-amd64.exe
With those two line changes, not seeing any other initial problems with using Python 3.11
Test python 3.11.1:
Install python-3.11.1-amd64.exe with default installation settings
py -3 -m pip install wheel
cd build-scripts
build_windows_installer.bat
cd ../dist
Install edkrepo 3.1.0 through EdkRepoSetup-3.1.0.0.exe
Installation Successful
run some test commands:
edkrepo manifest
edkrepo clone
edkrepo status
edkrepo combo
edkrepo checkout
edkrepo sync -u
python 3.11.1 basic functional tests pass
from edk2-edkrepo.
Confirmed, the Windows installer does not support Python 3.7.9. It is a hard installer failure, not optional:
Test python 3.7.9: fail
Install python-3.7.9-amd64.exe with default installation settings
Install edkrepo 3.1.0 through EdkRepoSetup-3.1.0.0.exe
Installation Failed:
"""
Found Python 3.7.9
Error: Python version 3.8.8 or later is required to run EdkRepo. Please install it before continuing.
Installation Failed.
"""
from edk2-edkrepo.
Related Issues (20)
- EdkRepo Sync Flow Change: When a manifest update is required abort the sync operations unless -o or -u is specified
- Sync Enhancement: Add option to update all refs
- Sync Enhancement: Tell users what changed during a manifest update
- Add --prune to EdkRepo cache update
- Add sparse checkout data to pin files
- Add option to skip garbage collection in edkrepo maintenance command
- install.py uses wrong installation mode
- Enable Checkout Pin to Accept a Path to a Locally Stored Pin File HOT 1
- Combo Output Enhancment
- Add Option to View Remotes for All Repos in a Workspace
- Status Output Enhancement
- Add combo details when running edkrepo manifest -v
- Installation Error: ModuleNotFoundError: No module named 'pkg_resources' with Windows Python 3.12.x HOT 1
- Do not suppress Git's colored output
- Support Git Partial Clone Methods
- Enable Git Partial Clone Method: Treeless
- Add a draft title or issue reference here
- Enable Git Partial Clone Method: Blobless
- Update required minimum version of Git
- Implement a Method to Clone a Single Repo
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from edk2-edkrepo.