Comments (6)
Sad to say, that may be a mistake on my part to be honest.
I was making changes in real time to help address an issue for another user at the so may have overlooked that
I will try sort that out
from threenine.data.
Any hint as to the direction and timeline on this? I'd like to use this library in a new project, but if it's about to have a breaking change, I may hold off. I'm assuming you'll add methods so you'll have support for both FirstOrDefault and SingleOrDefault. I guess I'm a little leery of how long that might take, given that we'll be writing code and having to remember that it's really not doing what we think it's doing in the meantime, and that it might suddenly change/correct one day if/when we update the package.
Hopefully that makes sense. Nice project though - I like it more than the others I've reviewed.
Thanks-
from threenine.data.
Implementing the fix now. This will obviously be a breaking change version update.
I incremented the version to 4.0.0 should be ready to install by the time you read this.
Thanks for pointing this out! Clearly I missed that.
from threenine.data.
Hey not to pile on, but if you're making changes, what do you think about adding support for AsSplitQuery?
I was thinking it might just be another optional boolean on the method like, and then conditionally tacking it on to the query:
public async Task<T> SingleOrDefaultAsync(....bool asSplitQuery = false) {
...
if (asSplitQuery) query = query.AsSplitQuery();
...
}
But I have not had a chance to actually test it. Could always do it later as a non-breaking change too. Just thought I'd mention it.
Thanks again-
from threenine.data.
If I'm perfectly honest, I don't even know what a split query is. I've not come across that specific functionality so I'd have to get my head round it first and understand it.
Feel free to submit a Pull Request with your initial thoughts or ideas and I can evaluate whether if it works.
I was considering implementing the Specification Pattern for the methods to enable creating Query specifications which would make the process of defining queries a lot better, instead of having so many argument overloads on the methods.
from threenine.data.
BTW I moved the Split Query request to a new issue as I will go ahead and close this one.
Thanks all for the feedback its really appreciated helps me to focus on the library knowing that people are actually using it out there!
from threenine.data.
Related Issues (20)
- Readonly repository HOT 2
- GetList Order By HOT 1
- simple context HOT 3
- Need an example, how to inject dependency in Console App (.NET Core) HOT 2
- Provide example of Create, Update, Delete Api Examples. HOT 3
- provide sample for Projection & Including HOT 3
- Get All Items HOT 1
- Unable to cast object of type IRepositoryReadOnly, IRepository and IRepositoryAsync
- Implement Unit test Coverage
- cant find update method in Async Repository. HOT 1
- Use GetRepository and GetRepositoryAsync at same service throughs an exception HOT 3
- I have a catalog database and a profile database HOT 11
- Write Documentation HOT 2
- Implement Readthedocs
- Create Product Page
- Use Myget for Dev package release
- Implement Split query functionality
- Functionality to get a single Item
- Provide Sample Applications
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from threenine.data.