Release 23.2: UpstreamPathTemplate doesn't contain the same placeholders in DownstreamPathTemplate about ocelot

[ggnaegi]

No, unfortunately, I can't show you the delegating handler code. I catched the problem on staging environment.

[Fabman08]

@raman-m I've the same problem with the following configuration

"UpstreamPathTemplate": "/{serviceVersion}/myService/{any}",
"DownstreamPathTemplate": "v3.0/api/myRemoteService/{any}"

In my case it doesn't matter what {serviceVersion} is set on the UpstreamPathTemplate, the DownstreamPathTemplate must forwards request to version v3.0

[ggnaegi]

Yes, I can provide the fake delegating handler. I could write the acceptance test too.

[raman-m]

Now I'm testing the hotfix... I'll open a PR soon...

[raman-m]

@ggnaegi @RaynaldM @Fabman08
Welcome to code review for #2032 !

• #2032

@ggnaegi
You could add acceptance test for your user scenario if you want.

[raman-m]

@ggnaegi
Thanks for reporting!
What environment did you catch the problem in? Production or development?

And, first of all, show the code of your delegating handler please.

[ggnaegi]

As mentioned, there are plenty of possible use cases where you could end up with the placeholders not matching. It's quite obvious in my opinion.

[raman-m]

In my opinion this is not so obvious.
I don't see delegation handler code or overridden services in DI. Impossible to advise or discuss what is hidden.
It's very strange to report a problem and then talk about the code being closed.

Our project is an open source project ❗

All discussions and source code should be publicly available.

[ggnaegi]

I don't want to argue about this any longer, thanks. I think we have added to much validation there, that's it. I will come back with a new PR later.

[raman-m]

🤯 🤣

No, we will continue to search for an ideal solutions...
This is our destiny!

[ggnaegi]

🦄 👑 🌈

[raman-m]

I'm using a delegating handler to transform some upstream route parameters before calling the downstream service. eg. upstream: api/v1/service/endpoint/{upParam1}/{upParam2} -> downstream api/v1/internal-service/endpoint/{downParam}. It was working like a charm, since Release 23.2 it's not possible anymore.

@ggnaegi
How to emulate your user scenario?
Can we test it? I expect it is necessary to write a fake delegating handler in acceptance test.
Is it a new feature or custom hybrid setup in your app?
Will you help to write acceptance test?