Coder Social home page Coder Social logo

Comments (5)

bkielbasa avatar bkielbasa commented on July 19, 2024

IMO utils package is a bad sign. It says nothing about what's there. You can call this file for example endpoint.go. WDYT?

from watermill-amazonsqs.

p4tin avatar p4tin commented on July 19, 2024

I can rename the file to endpoint.go but it is common between SQS and SNS so utils was going to be the name of the package and then the files can be name more appropriately does that sound better?

from watermill-amazonsqs.

m110 avatar m110 commented on July 19, 2024

I agree that utils sounds too generic, but first we need to decide if we want to keep SNS and SQS in separate packages? We could also keep all in aws package, but I'm not sure yet if that sounds reasonable.

from watermill-amazonsqs.

bkielbasa avatar bkielbasa commented on July 19, 2024

both queues are IMO completely different so IMO it sounds better to separate them. It simplifies the implementation.

from watermill-amazonsqs.

p4tin avatar p4tin commented on July 19, 2024

If you separate them completelty a lot of code would be duplicated... I would like to see a the Adapter be "aws" with "sqs" and "sns" packages. We could leave common structs and code in the "aws" package and the specific structs and code in the defined packages. This might also allow for the creation of a "s3" package in the future to deal with S3 file flows... See PR #2 I think it's in that shape.

from watermill-amazonsqs.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.