Comments (3)
By default Go will only unmarshall JSON data which it knows about (unless just put into an interface{}) so any extra fields added will be ignored with no failure or error by design. Support specifically has to be added for it. Out of curiosity, are seperators sent in the extra data for currency pairs?
from gocryptotrader.
Yeah cool. Those fields are for me to easily handle things in the front-end. I strip any known seperators to be able to compare enabled currencies.
Good to know that the extra JSON isn't considered. GCT server doesn't need to care about it.
from gocryptotrader.
SetConfig cannot save if there are any warnings. I think that is fine, however, the reason for the warning I think should be removed.
After looking at WS response I got the following:
{"event":"SaveConfig","data":"OK","error":"WARNING -- SMS Support disabled due to default or empty Username/Password values."}
I feel like this should be removed. If a user runs GCT for the first time using front end, they will be unable to save until they modify the SMS details even if they do not want to change/use SMS settings. So a user will have to put gibberish into SMS settings to get past this warning.
This also applies to enabled contacts. These warnings should only come up if SMS support is enabled:
On the upside, I now display any errors to the user:
from gocryptotrader.
Related Issues (20)
- Excuse me, are there some examples that can teach me how to use gocryptotrader to write a strategy in golang? HOT 1
- The startTime and endTime must be millisecond on Binance query deposit list. HOT 1
- could not find a copy of typescript to link HOT 1
- Binance websocket example
- Bug in Syncmanger does not allow for tickersync only. HOT 1
- any plan to support mexc? HOT 2
- Plase Help Me ... HOT 1
- Dispatcher tries to return used channels that are `<-chan interface{}` as `chan interface` and fails
- Buy/Sell/Ask/Bid actions do not have an expected outcome
- Bitstamp: depreciated balances *_usd _ fee
- Bitfinex: WS cancel stuck waiting for confirmation HOT 1
- Bitfinex: Switch WS type assertions
- pls add support commex.com HOT 3
- Request for supporting Upbit
- When set kline.interval to OneMonth, AddPaddings error
- database reconnection
- Error: ITBIT: pair config format is nil HOT 3
- Change leverage for Binance margin asset
- Bug in datahistorymanager HOT 4
- Bug in gateio_wrapper.go , it should be 'y' HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gocryptotrader.