Coder Social home page Coder Social logo

Comments (2)

victorhazbun avatar victorhazbun commented on August 14, 2024

@cllns The Gem.lock shows it has Capybara v3+ on the tag v.0.2.0 https://github.com/thoughtbot/fake_stripe/blob/v0.2.0/Gemfile.lock

from fake_stripe.

cllns avatar cllns commented on August 14, 2024

That Gemfile.lock isn't included in the gem distribution (and it shouldn't) be: https://github.com/thoughtbot/fake_stripe/blob/v0.2.0/fake_stripe.gemspec#L14 You can also see this with gem open fake_stripe (or bundle open stripe), there's no Gemfile.lock.

The Gemfile.lock specifying Capybara v3 makes sense, since it shows that CI passes with v3. What I'd propose is adding ~> 3.0 (or whatever minor version is desired) here: https://github.com/thoughtbot/fake_stripe/blob/v0.2.0/fake_stripe.gemspec#L16

@victorhazbun More on how *.gemspec vs Gemfile.lock. The author suggests not checking in the Gemfile.lock, but the most important part is that it's not included in the distribution: https://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/

from fake_stripe.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.