factory_girl_rails should probably require "factory_girl" about factory_bot_rails

[joshuaclayton]

Jose, could you elaborate a bit?

https://github.com/thoughtbot/factory_girl_rails/blob/master/lib/factory_girl_rails/railtie.rb#L1

Thanks!

[josevalim]

Thanks @joshuaclayton , I haven't seen this line. I just opened this issue because I am getting this error:

workshop/spec/factories/all.rb:3: uninitialized constant Factory (NameError)
    from /Users/jose/.rvm/gems/ree-1.8.7-2010.02/gems/factory_girl-1.3.3/lib/factory_girl/factory.rb:314:in `find_definitions'
    from /Users/jose/.rvm/gems/ree-1.8.7-2010.02/gems/factory_girl-1.3.3/lib/factory_girl/factory.rb:313:in `each'
    from /Users/jose/.rvm/gems/ree-1.8.7-2010.02/gems/factory_girl-1.3.3/lib/factory_girl/factory.rb:313:in `find_definitions'
    from /Users/jose/.rvm/gems/ree-1.8.7-2010.02/gems/factory_girl-1.3.3/lib/factory_girl/factory.rb:308:in `each'
    from /Users/jose/.rvm/gems/ree-1.8.7-2010.02/gems/factory_girl-1.3.3/lib/factory_girl/factory.rb:308:in `find_definitions'
    from /Users/jose/.rvm/gems/ree-1.8.7-2010.02/gems/factory_girl_rails-1.0.1/lib/factory_girl_rails/railtie.rb:11

Seems to be an error on my end then. I will handle it here. Sorry for the buggy report!

[joshuaclayton]

No worries - I'd just double-check the gemfile and all the other basic stuff first. If you're still having trouble, reopen the ticket and we'll try and figure it out. Thanks!

[seivan]

Hmm.. could you reflect the getting started document in the factory_girl repo to suggest rc 1.1
We used that syntax and got uninitialized constant FactoryGirl errors without realizing it only worked on Rc 1.1