Follow the -rails convention of rspec and cucumber about factory_bot_rails

[jferris]

I would have done this originally except that factory_girl has an underscore in the name, and I think the combination of underscores in hyphens ("factory_girl-rails") is pretty ugly. That being said, I'm not opposed to renaming it if a number of people are annoyed by the inconsistency.

[bcardarella]

I guess I can see that, I'm just looking at it as name-adapter_for. So the name does a camelcase mapping to the class. And the adapter_for is always easily detectable. I'll see if I can get some people to comment. It would be nice if the community could standardize on something.

[bcardarella]

Just realized how stupid the 'camelcase' argument is with 'rspec' -> RSpec. But I think you know what I mean

[soffes]

"factory_girl-rails" doesn't bother me that much when you mention camelcase mapping to the class.

[francois]

I'm fine with using both as well. It makes it clear what belongs to what.

[jferris]

I've thought about this, and I don't think there's a strong enough convention in the community that I'm willing to use "factory_girl-rails" because of how ugly I think the mixed underscores and dashes are. Thanks for your input.