Comments (2)
Apart from method's complexity, some of our codes have an ordering dependency on header include. (Transitive inclusions)
The google c++ style guide provides some concepts to solve this problem.
https://google.github.io/styleguide/cppguide.html#Include_What_You_Use
https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes
what do you think about it?
from thorvg.
@JSUYA Conceptually, each file should explicitly include headers if they depend on them. The problem is that somebody might forget to include a header, and it's not easy to detect this omission during the review stage because even reviewers may not notice it when transitive inclusions implicitly hide it. In my case, I'm not overly concerned about this, as any breakage can be promptly detected during testing. We can easily identify the missing header in the necessary file, allowing us to include it at that time.
The only header that truly matters for the transition is the client API header (thorvg.h/thorvg_capi.h) for us. And I believe it's well maintained.
from thorvg.
Related Issues (20)
- Memory problems that occur when the wasm class is destroyed HOT 2
- Corrupt radial gradient on Apple Silicon HOT 5
- Incorrect outline for specific curve HOT 1
- Hash collisions in SVG loader HOT 4
- Lottie regression bug HOT 1
- Add c/c++ test suites for lottie slot
- Apply clang-format HOT 1
- Lottie loader is not updating the canvas HOT 8
- Metal backend support?
- Adding a web build test CI HOT 2
- Lottie: Animation Segment(Marker) Support
- Lottie/slot: multiple properties in single slot not working
- broken lottie trimpath (individual)
- Feature Request: Clear canvas without deleting paints HOT 2
- Storing the address of local variable HOT 2
- CAPI: update colorspace interfaces
- Lottie: Support feasibility of accessing a specific Lottie node by identifier
- Lost compose effect when call canvas::draw second time
- lottie compatibility issue HOT 2
- Embedded compilers doesn't like `_A`, `_B`, and `_C` function names.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from thorvg.