Coder Social home page Coder Social logo

Comments (4)

thomaspoignant avatar thomaspoignant commented on June 12, 2024

Hello @Rongtao-Fu-Imprivata, this is actually a super nice idea and we should consider this for sure.
I think this is definitely a good way to improve the relay-proxy.

Let me try to find time to work on this in the near future or if you want you can contribute to the relay-proxy by opening a PR for that.

We could to the echo middleware https://echo.labstack.com/middleware/prometheus/

from go-feature-flag.

thomaspoignant avatar thomaspoignant commented on June 12, 2024

Also @Rongtao-Fu-Imprivata I would be interested to know which metrics you would be interested in.
Are API calls enough or do you want more than that, such as a refresh of the configs etc ... ?

from go-feature-flag.

Rongtao-Fu-Imprivata avatar Rongtao-Fu-Imprivata commented on June 12, 2024

Evaluation API call metrics like response time, size in bytes, success/failure rate are super helpful to monitor the service performance, throughput, reliability. Other interesting metrics can be number of evaluation rules, how often those rules are added/removed/updated, response time, success/failure rate to retrieve evaluation rules from an external storage, which can be helpful for evaluation rule management. This flagd PR may be helpful as well to see what metrics flagd supports

from go-feature-flag.

thomaspoignant avatar thomaspoignant commented on June 12, 2024

@Rongtao-Fu-Imprivata I have opened this pull request #555 that is providing a /metrics endpoint that is exposing the prometheus metrics.

Can you have a look at the pull request and tell me if it is aligned with what you had in mind?

from go-feature-flag.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.