Comments (7)
Hi @FuturistiCoder,
Thanks for the report. I was able to reproduce the problem with SDK 3.1.300.
This is strange, though... It works fine with 3.1.100, and with 5.0.100-preview.4, but not with 3.1.300, so I suspect a regression in the .NET SDK itself...
I'm looking into it.
from internalsvisibleto.msbuild.
Ah, I see.
They changed the target in which the AssemblyInfo.cs file is generated. It used to be done during CoreCompile
, but now it's during BeforeCompile
.
The AddInternalsVisibleTo
target runs right before CoreCompile
, so at this point the AssemblyInfo.cs file has already been generated and it's too late to add new attributes.
I'll move it to BeforeCompile, which hopefully should still work for other SDK versions
from internalsvisibleto.msbuild.
I just pushed a new version to NuGet, it should fix the problem.
from internalsvisibleto.msbuild.
Did that fix the problem for you @FuturistiCoder?
from internalsvisibleto.msbuild.
Did that fix the problem for you @FuturistiCoder?
Thanks for the fix. I'm using old style for now, and waiting for Net5. dotnet/sdk#3439
cause I don't know whether they will change it recently.
from internalsvisibleto.msbuild.
waiting for Net5. dotnet/sdk#3439
Ah, I wasn't aware of this. So I guess this library will become useless in .NET 5... I'll probably need to do something (don't emit the attributes, and maybe emit a warning) when using .NET 5 SDK, otherwise it will cause conflicts.
from internalsvisibleto.msbuild.
For future reference, the change that caused the issue was dotnet/sdk#10614.
from internalsvisibleto.msbuild.
Related Issues (2)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from internalsvisibleto.msbuild.