Comments (12)
Yes the test passes on the travis build.
from sea.
Have you solved this issue?
from sea.
Yes, it seems to. It just worked after i tried it two more times.
The test uses some random generation, maybe that is the problem - even though it uses a fixed seed.
from sea.
Now also fails for me. #36
from sea.
I'm going to look into it, however I'm not able to reproduce this behaviour locally.
Now also fails for me. #36
Does it make a difference if you comment out line 28 in choicedictionaryiterator_test.cpp?
from sea.
Does it make a difference if you comment out line 28 in choicedictionaryiterator_test.cpp?
Yes it does, but the test still fails. Now the actual value is 1624
instead of 3260
.
Let's see if Travis accepts it.
from sea.
@andrej-sajenko Should we maybe disable the test for the choice dictionary iterator, so that unrelated pull requests get accepted?
I'm going to look further into it to find the problem, as it doesn't seem to be related to shuffling the test set.
@shsr04 Does the test also fail locally?
from sea.
Yes, it's the same as the Travis build.
from sea.
Maybe the -O3
compiler flag introduced one month ago breaks the GCC built-in __builtin_clzl
used in the iterator:
sea/src/choicedictionaryiterator.cpp
Line 38 in f4747b3
sea/src/choicedictionaryiterator.cpp
Line 61 in f4747b3
from sea.
@dappels I have made several tries now. Whatever my approach for the CD iterator test is, it fails on Travis (but works locally)... Could this be a bug in the iterator itself? (some portability issue?)
from sea.
I don't really know what causes the issue for you. As discussed previously it is not possible for me to reproduce that issue locally.
Is there any sign of the iterator returning incorrect values when you run it locally? Be it in an implementation that relies on it or the unit test?
from sea.
The Travis build on #68 failed when I uncommented the test. (Locally, everything works.)
I also made a few different random tests (e.g. 641c791, e8ddd2e) to see if Travis accepts those. (Again, every one of those works locally.)
What's really interesting is that the experimental test e8ddd2e does not even use random number generation. The build status can be found here: https://travis-ci.org/thm-mni-ii/sea/builds/455994593
I don't know if this helps, but that's all the information I have.
from sea.
Related Issues (20)
- In-Place Initializable Arrays HOT 2
- bfs_test.cpp fails HOT 2
- Master Failed
- Import/Export to the DIMACS graph file format
- BFS_Test fails when using gcc compiler instead of CLang HOT 1
- Implement new space-efficient graph representation
- Implement improved rank/select structure
- Move to atleast c++17, better c++20
- Refactor to a header-only library
- Improve the doc comments. HOT 1
- Rank-Select
- Expand Bitset HOT 5
- Visualisation
- Linear Time DFS HOT 1
- g++ linker errors HOT 2
- Master is not up to date HOT 1
- Hierholzer's Algorithm
- Ignore external files from coverage results HOT 1
- Implement rvalue constructors, rvalue assignment and the move function for all container classes HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sea.