thinkmill / code-challenge Goto Github PK

Should be skipAction = true; instead of return after the Penalty

Would be great to give each challenge a name, and use that in the name of the challenge's folder. It makes walking the project from the command line nicer.

Pls close if you donotwant this.

To make an informed decision on the bot side we need to give the counter action to the bot inside the OnCounterActionRound.

Hello!

Is there a reason we're doing selection sort and merge sort, rather than some other flavour like bubble sort?

The code currently has foreign-aid as an action which can be challenged, but not countered. It should be the other way round.

		if( action === 'taking-3' || action === 'assassination' || action === 'stealing' || action === 'swapping' ) {
			const cards = {
				'taking-3': 'duke',
				'assassination': 'assassin',
				'stealing': 'captain',
				'swapping': 'ambassador',
			};

			const _hasBeenChallenged = this.ChallengeRound({ player, card: cards[ action ], action, type: 'challenge-round' });
			if( _hasBeenChallenged && _hasBeenChallenged !== 'done' ) {
				return;
			}
		}

		if( action === 'assassination' || action === 'stealing' || 'foreign-aid' ) {
			const cards = {
				'assassination': 'contessa',
				'stealing': [ 'captain', 'ambassador' ],
				'foreign-aid': 'duke',
			};

The bots currently only get name and coins. Also need card count.