Error when running EndToEndTest.php unit test about grpc-php7

[stanley-cheung]

Figured it out. There should be a line

memset(ops, 0, sizeof(ops));

around here: https://github.com/thinkerou/grpc-php7/blob/master/ext/grpc/call.c#L299

[stanley-cheung]

Now I am running into segfault in CallTest.php

Starting test 'CallTest::testAddEmptyMetadata'.
./bin/run_tests.sh: line 41: 20195 Segmentation fault      php $extension_dir -d max_execution_time\
=300 $(which phpunit) -v --debug ../$1

[stanley-cheung]

The segfault seems to come from this grpc_channel_create_call: https://github.com/thinkerou/grpc-php7/blob/master/ext/grpc/call.c#L253

[stanley-cheung]

Nevermind, my fault. Now all unit tests run successfully. Let me review the code more closely now.

[thinkerou]

Ohhh, really lack a line: memset(ops, 0, sizeof(ops)); https://github.com/thinkerou/grpc-php7/blob/master/ext/grpc/call.c#L299
Thanks @stanley-cheung , I have added it.

[stanley-cheung]

I believe for this line: https://github.com/thinkerou/grpc-php7/blob/master/ext/grpc/call.c#L255, the value for host_override needs to be host_override == NULL ? NULL : ZSTR_VAL(host_override)

[thinkerou]

Yeth, If str is null when calls ZSTR_VAL(str), this will crash. So, you are right.