Unused variable warning on ESP8266 about esp8266-oled-ssd1306

[marcelstoer]

@benoitm974 what is your take on this? I ask for your opinion as you contributed the code in question back then.

[nyanpasu64]

I actually feel the "unused arguments" warning is too noisy and turn it off in my personal projects, but it's difficult to set custom compiler flags on Arduino IDE v1, and reducing the warning level turns off other useful warnings as well. In this case I think (void)_i2cBus isn't too ugly of a change to make.

In any case, should the _i2cBus argument even exist outside of ESP32? Though removing the argument on some platforms can break code on a platform-dependent basis, which is even worse than leaving it in.

Should the HW_I2C type only define I2C_TWO on ESP32, and otherwise be a one-value enum to prevent users from passing in I2C_TWO on ESP8266 which is silently ignored? Or is it better to leave I2C_TWO in?

[benoitm974]

@marcelstoer Thanks for the head up and kind attention on this contribution.

Since this code is executed at init only why don't we secure it by adding a test/assert in case someone is trying to use a second wire on another ESP32 platform with no 2nd Wire?

#if !defined(ARDUINO_ARCH_ESP32) //assert on trying to use a second wire on non-ESP32 platform. assert(_i2cBus!=I2C_ONE) this->_wire = &Wire; #else this->_wire = (_i2cBus==I2C_ONE) ? &Wire : &Wire1; #endif

Benoit