install on Heroku fails about node-neo4j

[aseemk]

This was quite tricky, but I realize what's going on!

> [email protected] postinstall /tmp/build_20zj9urr4tkew/node_modules/neo4j
> npm run build

sh: npm: not found

Heroku doesn't come with npm available to npm scripts. Very strange this way. We use npm in multiple ways during our top-level app's install scripts, so we had worked around this by simply adding npm as a dependency itself.

This lib should absolutely work on Heroku without workarounds, so I'll fix this. In the meantime, would you be able to simply add npm as a dependency to your project?

I'll also bug Heroku to ask why npm isn't available. Thanks for reporting!

[ethul]

Great! Your suggestion worked like a charm.

Thanks,
-Eric

[aseemk]

Hey @ethul, this seems to be fixed for me. Can you test it from your app too? (By removing the explicit npm dependency and redeploying.) Thanks!

[ethul]

Thanks @aseemk I will test this on my next deploy and report back.

[ethul]

Hi @aseemk, I just ran a deploy and still see the error.

[aseemk]

Thanks for testing @ethul! Okay, I'll continue working with Heroku to fix this.

[ethul]

Welcome @aseemk, keep me posted. I am happy to re-test.

[athieriot]

Hi everyone,

I encounter exactly the same error on Heroku with the version 0.2.19 or node-neo4j

  sh: npm: not found
  npm ERR! [email protected] postinstall: `npm run build`
  npm ERR! `sh "-c" "npm run build"` failed with 127

Any news?

Thank you very much

[aseemk]

Sorry @athieriot, I haven't made time to do this yet. You're aware of the workaround mentioned above, of simply adding npm as a dependency in your package.json, yes?

[athieriot]

Yeah the temporary fix is working anyway :) Thank you.

After looking around, though, I think it should be fix in the corresponding Heroku buildpack.
There is a reported issue and a pending Pull Request on the project.

Let's see how that goes.

[aseemk]

Yes, it's indeed Heroku's Node.js buildpack that should be fixed. Great to hear the workaround works for now!

[flipside]

Personally, I think precompiling the javascript in the next version submitted to npm and removing the build command would be simplest.

[athieriot]

Hi !

Just to warn you that it seems the workaround is not working anymore with Node.js 0.10.x

[aseemk]

Sorry for the delay in responding, @athieriot, but yes, you're right! Looking into this now.

@flipside: you might be right. =)

[aseemk]

Okay, fixed as @flipside recommended; installation of this library now works on Heroku out-of-the-box even with Node 0.10. Thanks for the heads-up @athieriot!

[athieriot]

Really great!

Thank you

[aseemk]

No prob at all.

Forgot to mention: this pre-compiled version is published on npm as 0.2.20 now, so be sure to update your package.json and/or npm-shrinkwrap.json if you need to.

[zishon89us]

@aseemk problem still continues on heroku;
I just tried it one machine with 0.2.20 and included npm as dependency then it worked

[aseemk]

Very strange @zishon89us. You shouldn't have had to do that, but it's good that at least it's working for now. If you're still interested in figuring out the issue, let me know. Otherwise, let me know if it stops working again.

[zishon89us]

@aseemk I would try it on other machine, will update you soon.

[sonoman]

Hi there:
I'm having the same problem, only that in my case, I'm trying to execute a "preinstall" script, calling "npm install ./src/" to build a package that's below my package root....so i don't know how could i add npm as dependency......

npm install ./src/
sh: npm: not found
npm ERR! [email protected] preinstall: npm install ./src/

Any help will be very much appreciated

[aseemk]

@sonoman: you're having the same problem, meaning node-neo4j won't install on Heroku for you?

Or do you mean you're seeing a similar error unrelated to node-neo4j? The error sh: npm not found refers to the fact that npm isn't installed globally on Heroku at build-time. So adding it as a dependency means adding it to your package.json. E.g.:

"dependencies": {
    "npm": "1.x"
}

[sonoman]

that's the case (I'm doing something similar and getting the same problem).
Thanks for the suggestion, it worked fine ;)

On Mon, May 6, 2013 at 4:39 PM, Aseem Kishore [email protected]:

@sonoman https://github.com/sonoman: you're having the same problem,
meaning node-neo4j won't install on Heroku for you?

Or do you mean you're seeing a similar error unrelated to node-neo4j? The
error sh: npm not found refers to the fact that npm isn't installed
globally on Heroku at build-time. So adding it as a dependency means adding
it to your package.json. E.g.:

"dependencies": {
"npm": "1.x"}

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/35#issuecomment-17503100
.