New squid breaks things about puppet-squid3

[bhechinger]

Looks like this was changed in 3.2

http://wiki.squid-cache.org/SquidFaq/ConfiguringSquid#Squid-3.2_default_config

[bhechinger]

I've created a pull request for this:

#16

[sjpilot]

I've confirmed there is an issue with the config file and I receive the same errors. Ubuntu 14.04 installs 3.3.8 and it will fail on this.

I tested bhechinger's fork but I couldn't get it to work. I added a debug notice line but the version number is blank because /usr/sbin/squid3 is not yet installed

==> proxy: Notice: Scope(Class[Squid3]):  is older than 3.2.0, including manager acl entries
==> proxy: Notice: Compiled catalog for proxy in environment production in 0.75 seconds
==> proxy: Notice: /Stage[main]/Squid3/Package[squid3_package]/ensure: ensure changed 'purged' to 'present'
==> proxy: Notice: /Stage[main]/Squid3/File[/etc/squid3/squid.conf]/content: content changed '{md5}b3f77e1a2622bba2d1e90d5e6b904268' to '{md5}b105653aee30e55f5b4ab5b72f4e64b7'
==> proxy: Error: Could not start Service[squid3_service]: Execution of '/usr/sbin/squid3 start' returned 1: 

FYI here's the latest commit that should be pulled/tested: "wrong format"
bhechinger@9af0adb

[bodepd]

I ran into this issue on Ubuntu Trusty, and had a look at this patch. I'm not a fan of using facter for this reason b/c it will require 2 runs to get things working. Why not just not have any acls in the file by default and allow users to pass in [] to remove the non-functional entries. Are we sure in which versions these things are required vs. not-required?

[bhechinger]

Why does facter require two runs? (I'm genuinely curious)

I'd rather the user didn't need to know, this is something the module should be able to handle.

Yes, I checked the squid docs and the split I have in the pull request is what matches that documentation.

[bodepd]

one run to install the squid executable, then facter can work (b/c it has to happen at the beginning of the run. It would be better to just pass it as a class parameter.

[bhechinger]

ah, crud, I hadn't thought of that. Is there anyway to get facter to rerun after the package install?

[bodepd]

nah, that order of things is pretty fundamental in Puppet.

The best thing is to allow version to be passed via a class param (and perhaps set to a different default for trusty)

[bhechinger]

Ok, I still don't like that. It feels wrong to me for the admin to have to know what version of squid is installed. That really defeats the purpose of puppet.

I'm re-writing the squid_version fact to use the package management system (apt/yum) to determine which version would be installed.

I'll push it up as soon as I'm done with it.

[victorgp]

Well, at this moment this module is completely unusable. Is there any chance this will be eventually fixed?

[sjpilot]

Since it's been 6 months since the squid update that breaks the config was
discovered I would support dropping support for the old squid going
forward. Lets just modify the config template fixing to work and be done
with it.

The dynamically determination of version to be installed and selecting
configs to match is difficult and never eventuated.

On Wednesday, May 20, 2015, Victor Garcia [email protected] wrote:

Well, at this moment this module is completely unusable. Is there any
chance this will be eventually fixed?

—
Reply to this email directly or view it on GitHub
#15 (comment).

[thias]

This should have been fixed by the change in #13.