EF Interceptor should not crash the workflow if something fails during audit about audit.net

[thepirat000]

This was fixed in version 20.2.4, please upgrade your references and re-test

[thepirat000]

Please share your configuration (Audit.Core.Configuration.* and Audit.EntityFramework.Configuration.* calls) or share the code that reproduces the error

[thepirat000]

From the stack trace I can see you're using the EF data provider to save the audits and you save the audits within the same DbContext. So you're probably letting the default behavior of using the same DbContext instance for saving the audits.

But whenever the SaveChanges fails, the DbContext instance will be set to a faulted state or be disposed, so that's why the audit throws the exception.

You could change the EF Data Provider configuration to use a different instance of your DbContext for the audit, so any failure in the save operation will not affect the audit. For this, you must provide a way to instantiate your audit DbContext.

Some examples:

// Resolve using a parameterless constructor 
Audit.Core.Configuration.Setup()
    .UseEntityFramework(ef => ef
        .UseDbContext<StammdatenDbContext>()
        ...

// Resolve from IServiceProvider (i.e. your project is ASP.NET core MVC)
Audit.Core.Configuration.Setup()
    .UseEntityFramework(ef => ef
        .UseDbContext(ev => ev.EntityFrameworkEvent.GetDbContext().GetService<StammdatenDbContext>())
        ...

[lucax88x]

I'm not using UseEntityFramework extension, but UsePostgreSql extension instead, so my expectation is that it should use the npgsql driver to write audit stuffs and not the dbcontext audit. Does it make sense what I'm saying?

My configuration:

            Configuration
                .Setup()
                .UsePostgreSql(
                    config => config
                        .ConnectionString(dbConnectionString)
                        .Schema(Schema)
                        .TableName(Table)
                        .IdColumnName(IdColumn)
                        .DataColumn(DataColumn, DataType.JSONB)
                        .LastUpdatedColumnName(UpdatedDateColumn)
                );

how I add the interceptor:

    public static DbContextOptionsBuilder AddMyAuditTrail(this DbContextOptionsBuilder dbContextOptionsBuilder) =>
        dbContextOptionsBuilder.AddInterceptors(new AuditSaveChangesInterceptor());

// somewhere else
        services
            .AddPooledDbContextFactory<TD>(
                builder => {
                    if (addAuditTrail) {
                        builder.AddMyAuditTrail();
                    }

                    builder.UseNpgsql(
                            configuration.GetConnectionString(connectionStringKey),
                            optionsBuilder => {
                                optionsBuilder.EnableRetryOnFailure();
                            }
                        )
                        .UseLowerCaseNamingConvention();
                }
            );

How I create tables (by hosted service):

    public static async Task CreateTables(IConfiguration configuration) {
        var dbConnectionString = configuration.GetConnectionString(ConnectionStringKey);

        if (!string.IsNullOrEmpty(dbConnectionString)) {
            await using var connection = new NpgsqlConnection(dbConnectionString);
            await connection.OpenAsync();
            
            await using var createSchemaCommand = new NpgsqlCommand(
                $"CREATE SCHEMA IF NOT EXISTS {Schema}",
                connection
            );
            await createSchemaCommand.ExecuteNonQueryAsync();

            await using var createTableCommand = new NpgsqlCommand(
                @$"CREATE TABLE IF NOT EXISTS {Schema}.{Table} (
    {IdColumn} bigserial NOT NULL,
    {InsertedDateColumn} timestamp without time zone NOT NULL DEFAULT now(),
    {UpdatedDateColumn} timestamp without time zone NOT NULL DEFAULT now(),
    {DataColumn} jsonb NOT NULL,
    CONSTRAINT {Table}_pkey PRIMARY KEY (id) 
)",
                connection
            );
            await createTableCommand.ExecuteNonQueryAsync();
        }
        else {
            Log.Warning("No AuditTrail connection string found, not using any audit trail!");
        }
    }

[thepirat000]

You're right, in that case, I think the audit should not throw.

I would work on the fix to allow continuing with the audit process even if the DbContext got disposed of within the SaveChanges operation.