Problem with original request about route

[sagikazarmark]

For complete report:

I am running the latest proton (already using league/route) with php built-in server on PHP 5.5

[philipobenito]

The request object is fetched from the container so needs to be built within the container. I can take a look at Proton at some point or if @alexbilbie can take a look to ensure Proton is registering the request with the container?

Something like:

$container->add('Symfony\Component\HttpFoundation\Request', function () {
    return Symfony\Component\HttpFoundation\Request::buildFromGlobals();
});

In the meantime @sagikazarmark you could register it yourself within Proton by adding this somewhere within your bootstrap.

$app->getContainer()->add('Symfony\Component\HttpFoundation\Request', function () {
    return Symfony\Component\HttpFoundation\Request::buildFromGlobals();
});

[sagikazarmark]

@philipobenito thanks for your response. I am going to open a PR in Proton.

[philipobenito]

No problem, sorry for the delay

[jakefolio]

I had a similar issue with just working off of the http://route.thephpleague.com/getting-started/. Every time I tried to access a query param, there would be nothing.

I followed the instructions you gave here and added it to the container, and everything worked good.

This seems like a necessary step in accessing query params when using route. I'd either reopen this as a bug or update the docs on the getting started.

[philipobenito]

This is certainly something I can add for the 1.x branches that depend on Symfony\HttpFoundation, but v2 will actually depend on PSR-7 rather than a specific implementation with the documentation heavily padded out with some example implementations and how to build the requests within the app, along with v2 will come a skeleton web application (codename Sterling) and a skeleton restful API (codename Lana) that will both handle that for the user in the bootstrap and also provide a good example for anybody who wants to roll their own.

[philipobenito]

Will be addressed by #26