Stop requiring a container about route

[philipobenito]

Currently it is a hard dependency as DI is a big part of the strategy functionality but this is being looked at for possibly splitting out in v2.

Sent from my iPhone

On 21 May 2015, at 17:17, Woody Gilk [email protected] wrote:

There's no particular reason that league/container is a hard dependency, as it is only required when using the "Class Method" type of dispatching. Instead of being a required dependency, it should be suggested.

This would make it possible to avoid using league/container completely for those of us that prefer a different DI implementation.

—
Reply to this email directly or view it on GitHub.

[shadowhand]

I have to disagree with it being a "hard dependency", because it is only optional in AbstractStrategy.

[philipobenito]

Every class based controller is built via the container when using the strategies provided, so, yes it is currently a big part of the dispatch process, however, as I said, it is looking likely that the strategies will be split out, therefore allowing the container dependency to be moved to the strategy.

Sent from my iPhone

On 21 May 2015, at 17:33, Woody Gilk [email protected] wrote:

I have to disagree with this, because it is only optional in AbstractStrategy.

—
Reply to this email directly or view it on GitHub.

[shadowhand]

Exactly my point... it is only necessary when you use a classes as part of the strategy. Implementing a custom strategy allows me to avoid the container completely, but I cannot avoid having it installed. Hence, it should be suggested only.

[philipobenito]

This would be a breaking change to the package as a whole so it cannot be removed for v1, however, as the package allows you to do as you wish without using the container you are not required to use it. As stated, it's being reassessed for v2.

Sent from my iPhone

On 21 May 2015, at 17:50, Woody Gilk [email protected] wrote:

Exactly my point... it is only necessary when you use a classes as part of the strategy. Implementing a custom strategy allows me to avoid the container completely, but I cannot avoid having it installed. Hence, it should be suggested only.

—
Reply to this email directly or view it on GitHub.