CreatePlanRequest about omnipay-stripe

[jreviews]

In addition to moving the 'name' inside the 'product' object, it's also necessary to move the 'statement_descriptor' in CreatePlanRequest::getData because this also changed in the Stripe API:

        $statementDescriptor = $this->getStatementDescriptor();
        if ($statementDescriptor != null) {
            $data['product']['statement_descriptor'] = $statementDescriptor;
        }

Otherwise the API returns an error reporting an undefined statement_descriptor parameter.

[mitermayer]

Whats the status of this issue ?

[mitermayer]

If we dont include "name" we get

The name parameter is required

If we include name we get:

Received unknown parameter: name'

[markokeeffe]

This issue could potentially be resolved if the package were to set the correct "Stripe-Version" header (https://stripe.com/docs/api/versioning?lang=curl).

It's hard to tell exactly which API version the functionality of this package meets, but the changes to the parameters of the CreatePlanRequest happened after 2018-01-23 (https://stripe.com/docs/upgrades#2018-01-23).

This seems pretty vital to keeping this package functioning as Stripe can change their API at any time.

Edit: looks like there's already a PR for the API version header: #110