PHP notice error: undefined index `code` on Message/Response.php#L308 about omnipay-stripe

[acstll]

Ok, I checked Stripe's logs and found the cause of the error:

error: {
  type: "invalid_request_error"
  message: "Amount must be at least 50 cents"
  param: "amount"
}

Still this looks like a bug.

[kinglozzer]

Just encountered this too. The code key is optional (in fact, type is the only key guaranteed to be present): https://stripe.com/docs/api#errors. Looks like this code just needs an isset() (note, we should also add one to getMessage() as the message key is also optional). cc @delatbabel

[delatbabel]

OK can someone submit a PR for this please?

[acstll]

Yes, I could try a PR, but I have a doubt… documentation for both getCode() and getMessage() methods says Returns null if the request was successful., but that won't be true anymore if we add isset() to them. So wouldn't this change cause greater bugs? I mean, is people relying on getting null from any of these methods to check whether the transaction was successful or not?

[delatbabel]

I doubt that there would be any breakages. The getCode() and getMessage() functions in other gateways don't always return null on a successful request, and furthermore there is a separate isSuccessful() function to determine the success / failure of the request which is the correct function to use to determine failure status.

[judgej]

Should the core documentation be amended then, to state that code and message may be returned if available, regardless of success result?

[kinglozzer]

I’ve created a PR here: #67. These two methods will still always return null on success, that behaviour hasn’t been changed.

Getting this err:
Undefined index: code

Error is trigger from omnipay/stripe/src/Message/Response.php
lline 308

Checking the logs and updating this post.

[kinglozzer]

@MiguelSolano Make sure you’re running v2.4.2 or newer

You are absolutely right, it appears that Craft Cms is running a later version. I submitted a ticket and they are currently testing 💯