Coder Social home page Coder Social logo

Comments (5)

cfreear avatar cfreear commented on July 17, 2024

What is the exception you are receiving and could you provide an example of the card data you are passing incorrectly?

from omnipay-stripe.

aimeos avatar aimeos commented on July 17, 2024

The exceptions happen if obviously invalid data is entered like a too short card number or a expiry date in the past. Maybe this is checked upfront and an exception is then thrown without a request being made.

If this is a valid behavior, the Omnipay documentation should be updated because it says that exceptions should not be displayed to the customer.

from omnipay-stripe.

andrewtweber avatar andrewtweber commented on July 17, 2024

https://github.com/thephpleague/omnipay#credit-card--payment-form-input

If you submit credit card details which are obviously invalid (missing required fields, or a number which fails the Luhn check), InvalidCreditCardException will be thrown. You should validate the card details using your framework’s validation library before submitting the details to your gateway, to avoid unnecessary API calls.

This is expected behavior and the documentation is accurate. Just catch those exceptions and display an error message to the user.

from omnipay-stripe.

aimeos avatar aimeos commented on July 17, 2024

Would be great if someone would extend the documentation about error handling so others don't fall into this trap either: https://github.com/thephpleague/omnipay#error-handling

from omnipay-stripe.

andrewtweber avatar andrewtweber commented on July 17, 2024

Well it does say that exceptions are possible, and suggests wrapping the whole thing in a try/catch anyway. I'm not a member of Omnipay/the league btw.

from omnipay-stripe.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.