Issue with 'expires' logic in AccessToken entity about oauth2-client

[philsturgeon]

Doh.

Yes, I would say that Facebook-specific logic should ideally be moved to the Facebook provider. If other providers do similar, then maybe move that stuff to their providers too.

[jakelehner]

Ok I'll be submitting a pull request shortly. I'm not sure if you'll like this approach or not.

I was thinking I would be able to add a step to the facebook provider between making the token request and hydrating the token entity. Looking closer, this was not possible. The getAccessToken() method in the abstract provider calls handleResponse() immediately after receiving the response, so there's no opportunity for the specific provider class to do anything in the middle.

This can be addressed but is a larger effort that would need some additional thought.

I'll submit this pull request and see what you think.

[jakelehner]

Merged in PR 113