Comments (9)
Ugh. I sure would like to do away with the C code again, but it really was the best way to fix #315. Need to give this some thought.
from pgtap.
It isn't fully clear when this is appropriate to use, but looking at the C function is it safe enough to consider marking the extension as 'trusted'? Could be the least amount of friction... something to consider.
For reference: https://www.postgresql.org/about/featurematrix/detail/347/
from pgtap.
The extension must be marked with superuser=true
(which we forgot in #315) because C is an untrusted language. When also setting trusted=true
all the extension scripts and functions must follow a secure design. So it's not just the C function that needs to be checked here.
from pgtap.
But I think trusted=true
is not advisable if pgTAP relies on the search path as David explained: #325 (comment)
from pgtap.
I'm sorely tempted to dump the C code and replace it with your POC, @ewie. And also submitting a patch to get parseTypeString()
exposed in SQL in core.
from pgtap.
I'm sorely tempted to dump the C code and replace it with your POC, @ewie.
Your call, but it does seem like the best choice here.
And also submitting a patch to get
parseTypeString()
exposed in SQL in core.
Yeah, I was thinking about that too the last few days. You may still get it into pg17 with commitfest 2024-03 before feature freeze. Pre-17 releases should be stable enough for my PoC to cover all types (interval
still todo).
from pgtap.
I can take a stab at it, but I can't tell where the SQL function is created; it's not like extensions with CREATE FUNCTION
statements.
from pgtap.
Started a patch in theory/postgres#1.
from pgtap.
I can take a stab at it, but I can't tell where the SQL function is created; it's not like extensions with
CREATE FUNCTION
statements.
Builtin functions are defined in src/include/catalog/pg_proc.dat
. Picking an OID is described in
https://www.postgresql.org/docs/current/system-catalog-initial-data.html.
from pgtap.
Related Issues (20)
- table_privs_are is falsely reporting extra privileges HOT 4
- Question: pgTap on Greenplum? HOT 3
- How to use the return value of an insert? HOT 7
- [pg_prove] "tests out of sequence" failure with multiple checks in a single statement HOT 1
- Is Postgres 15 supported? HOT 1
- Regression test ruletap.sql failed due to recent change in PG16
- Unable to install on MacOS HOT 2
- New release with PG16 support HOT 10
- `col_type_is` cannot handle expected type `interval second(0)` HOT 24
- Add support for IDENTITY columns HOT 2
- add has_comment()
- Allow to test with snapshots HOT 2
- How to install and use pgtap in different schema? HOT 1
- passing the name of a test directory to pg_prove return 'Result: NOTESTS' HOT 1
- Cannot install pgTAP 1.3.1 HOT 4
- Function to check procedure privileges HOT 3
- Bad links in documentation HOT 1
- Feature: index_is_partial(), index_partial_clause_is()
- Feature: has_trigger_events() HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pgtap.