The Box Model: Small QOL improvment about curriculum

[RemanthManyam]

That's alright👍. Thanks again for your help!

…

On Sun, 12 May, 2024, 11:52 am MaoShizhong, ***@***.***> wrote: Just so you know, the issue gets left open. You've done your PR correctly where you've filled the form and set the "Closes" keyword to link to this issue, meaning once any maintainer approves and merges that PR, it will trigger this issue to close as completed. Until that point, or a maintainer manually closes the issue for whatever reason, it stays open while the PR's up. — Reply to this email directly, view it on GitHub <#27947 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AUF52GUCYVK3J7AF77V6BPDZB4DCXAVCNFSM6AAAAABHL5WDVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBWGEZTMMBQGM> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>

[MaoShizhong]

Thanks for opening the issue @RemanthManyam.

While I don't think there's actually any real problem with the current order vs image, I do think it makes sense to introduce the 3 parts in the p -> b -> m order, given that's the order they come in from the content box outwards. I'll assign you for this little change.

[RemanthManyam]

Thanks for looking into it and also assigning me. But I dont know what to do now as I'm new to GitHub😅. Can you help me out as to what is it that I need to do?

…

On Sat, 11 May, 2024, 11:31 pm MaoShizhong, ***@***.***> wrote: Assigned #27947 <#27947> to @RemanthManyam <https://github.com/RemanthManyam>. — Reply to this email directly, view it on GitHub <#27947 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AUF52GU37XUXS63QVW3GTYDZBZMF5AVCNFSM6AAAAABHL5WDVKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSG43TMOJUGMZTENY> . You are receiving this because you were assigned.Message ID: ***@***.***>

[MaoShizhong]

@RemanthManyam We have a contributing guide with all the information you'll need there.
Given you're still early in the curriculum and may not be as comfortable with Git yet, and that this is a fairly simple change to be made to a single lesson file (just swapping the order of the padding/margin/border list and the paragraph above it (I think those are the only bits that would need changing around), you can do so via the Improve on Github link at the bottom of the lesson page on the website itself.

As you get a little more experience with Git through the upcoming projects, for future PRs, you may wish to do things locally as per that contributing guide.

[RemanthManyam]

Thanks for the tip! I think I did it. It says "pull request is open" i'm guessing it means you have to close it on your end?..lol

…

On Sun, 12 May 2024 at 10:30, MaoShizhong ***@***.***> wrote: @RemanthManyam <https://github.com/RemanthManyam> We have a contributing guide <https://github.com/TheOdinProject/.github/blob/main/CONTRIBUTING.md> with all the information you'll need there. Given you're still early in the curriculum and may not be as comfortable with Git yet, and that this is a fairly simple change to be made to a single lesson file (just swapping the order of the padding/margin/border list and the paragraph above it (I think those are the only bits that would need changing around), you can do so via the Improve on Github link at the bottom of the lesson page on the website itself. As you get a little more experience with Git through the upcoming projects, for future PRs, you may wish to do things locally as per that contributing guide. — Reply to this email directly, view it on GitHub <#27947 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AUF52GWMYVQPHDLUOX3SNH3ZB3ZOLAVCNFSM6AAAAABHL5WDVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBWGEYTSMRWGQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[MaoShizhong]

Just so you know, the issue gets left open. You've done your PR correctly where you've filled the form and set the "Closes" keyword to link to this issue, meaning once any maintainer approves and merges that PR, it will trigger this issue to close as completed.
Until that point, or a maintainer manually closes the issue for whatever reason, it stays open while the PR's up.