Coder Social home page Coder Social logo

Comments (3)

PaulWAyers avatar PaulWAyers commented on July 21, 2024

I think having a tool for 3D structure comparison is sensible. When the number/type of atoms are not the same, however, it is more complicated (but could be done from graph similarity (2D) or fingerprint similarity (1D)). But I think as a Procrustes tool, only 3D similarity and (maybe) 2D (adjacency matrix) similarity make sense.

It may be that some of the tools are better added as utilities for DiverseSelector.

from procrustes.

FarnazH avatar FarnazH commented on July 21, 2024

We have examples among the existing notebooks for comparing 3D (using Cartesian coordinates loaded by IOData) and 2D structures (based on user-specified adjacency matrices; this can also be provided from RDKit, and we can update the example to show that) using procrustes functionality; see https://github.com/theochem/procrustes/tree/master/doc/notebooks. @PaulWAyers and @fwmeng88, can you please clarify the scope of this issue?

As we discussed within the context of DiverseSelector, it's best not to add these utilities/wrappers to our various packages. It's best to demonstrate how our packages can be used in conjunction with external libraries (e.g., IOData and RDKit) which are meant to generate structures, fingerprints, etc.

from procrustes.

PaulWAyers avatar PaulWAyers commented on July 21, 2024

I'm thinking about a utility function; it may be that it belongs in IOData or somewhere else. But we need to be able to compare molecules (in bulk, not via a notebook). In this case, I'm not sure that there is need for IOData or RDKit; one reads in a list of atomic numbers and their positions and processes directly. Probably we should discuss this now.

For 1D or 2D I don't see the need, right now, for stand-alone Python functions: Notebook-style examples would suffice I think.

from procrustes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.