stdClass member warnings about tmhoauth

[themattharris]

try adding this line to the top of the tmhOAuth class.
var $response = array();

so tmhOAuth.php will start something like:

class tmhOAuth {
  const VERSION = 0.621;

  var $response = array();
  /**
   * Creates a new tmhOAuth object
   *
   * @param string $config, the configuration to use for this request
   */
  function __construct($config) {

if that solves the issue let me know.

[trante]

Thank you. Warnings for response were disappeared.

But still IDE complains about request.
$code=$tmhOAuth->request('GET', $tmhOAuth->url('1/account/totals') );
Warning: 'void' method 'request' result used

I suppose this warning is IDE's bug?

[trante]

"request" function's warnings are solved when i changed phpDoc of function.
Return tag, from void to int.
Is "void" word typo there ?
Thank you

/**

• Makes a curl request. Takes no parameters as all should have been prepared
• by the request method
  *
• @return int response data is stored in the class variable 'response'
  */

[themattharris]

interesting, to be honest i should review those phpdocs. i don't use an IDE which reads them so these ommissions are generally obscured from me.
thanks for sharing your findings.

[trante]

Thank you for help.

[trante]

Hello, is there a change about this:
#47 (comment)

tmhouath->request has no "return" parameter in phpDoc.
Also in document it is written that function "Make an HTTP request using this library. This method doesn't return anything."
But we can get integer status code with $code=$tmhOAuth->request(...)
Which gives warning inside IDE.

All errors are suppressed when I add:
* @return int
to the phpdoc of request function.
But I think it should be added to commited version?
Or do I miss something?

[trante]

My IDE says that both of these two methods are defined as "returns void" inside PHPdoc. But when I use them I get $code as output. So my IDE gives warning. Everytime I download a newer tmhoauth version, I add @return int to the top of each function.
public function request($method, $url, $params=array(), $useauth=true, $multipart=false, $headers=array()) private function curlit()

[themattharris]

thanks. the PHPDoc got left behind when extra features were added. fixing that up now

[themattharris]

fixed in 0.7.3 and shipped